Menu

#28 the bitflags are not working

SVN
closed-fixed
nobody
General (76)
5
2004-07-26
2004-07-21
No

this code ( i added the comment )

debug_printf(DEBUG_INT, "Flags are (Y13): %02X\n",
thisint->flags);
thisint->flags &= (WAS_DOWN);
debug_printf(DEBUG_INT, "Flags are (Y14): %02X\n",
thisint->flags);

gives this debug output, which isn't what was supposted
to happen i think
[INT] Flags are (Y13): 07
[INT] Flags are (Y14): 00
7 = 1 2 4

#define WAS_DOWN 0x02

and the expected output was
[INT] Flags are (Y13): 07
[INT] Flags are (Y14): 05

conclusion:
the ... &= (!..) construction doesn't give the expected
result ;-)

(!WAS_DOWN) gives back '00' when i use the same
depug_printf as above

Discussion

  • Chris Hessing

    Chris Hessing - 2004-07-21

    Logged In: YES
    user_id=117575

    Problem resolved and pushed in to CVS. (It usually takes 24
    hours for developer CVS to be replicated to public CVS.)

     
  • Chris Hessing

    Chris Hessing - 2004-07-21
    • status: open --> closed-fixed
     
  • Robbert J. Muller

    fixes eap.c and xsup_driver.c

     
  • Robbert J. Muller

    • status: closed-fixed --> open-fixed
     
  • Robbert J. Muller

    Logged In: YES
    user_id=104494

    not all the places where fixed
    eap.c and xsup_driver.c
    are still using the broken way of removeing flags
    i'll attach to diff's

     
  • Chris Hessing

    Chris Hessing - 2004-07-26
    • status: open-fixed --> closed-fixed
     
  • Chris Hessing

    Chris Hessing - 2004-07-26

    Logged In: YES
    user_id=117575

    Remaining flags fixed, and pushed in to CVS. Thanks!

     

Log in to post a comment.