Menu

#12 wxhttpengine 2.0 crash in wxProxySettingsDlg

closed
5
2006-03-09
2005-12-09
jas
No

If wxProxySettingsDlg is called with
bShowNoProxyFor=false, there is an access violation
when the uninitialized m_tcExceptions is used during
Get/SetProxySettings.

--- proxysettingsdlg.cpp.orig Sat Nov 26 20:55:29
2005
+++ proxysettingsdlg.cpp Fri Dec 9 11:26:10
2005
@@ -47,6 +47,7 @@
{
m_stExceptionsDesc = NULL;
m_stExceptionsNote = NULL;
+ m_tcExceptions = NULL;

wxBoxSizer *sizer = new wxBoxSizer( wxVERTICAL );
wxBoxSizer *hsizer = NULL;
@@ -179,7 +180,8 @@
//! Set exceptions list as string
void wxProxySettingsDlg::SetExceptions(const wxString
&exceptions)
{
- m_tcExceptions->SetValue( exceptions );
+ if( m_tcExceptions )
+ m_tcExceptions->SetValue( exceptions );
}

void wxProxySettingsDlg::SetProxySettings(const
wxProxySettings &settings)
@@ -222,7 +224,10 @@
//! Get exceptions string
wxString wxProxySettingsDlg::GetExceptions()
{
- return m_tcExceptions->GetValue();
+ if( m_tcExceptions )
+ return m_tcExceptions->GetValue();
+ else
+ return wxEmptyString;
}

wxProxySettings wxProxySettingsDlg::
GetProxySettings(void)

Discussion

  • Angelo Mandato

    Angelo Mandato - 2006-03-09
    • labels: --> wxhttpengine
    • assigned_to: nobody --> amandato
    • status: open --> closed
     
  • Angelo Mandato

    Angelo Mandato - 2006-03-09

    Logged In: YES
    user_id=660980

    This problem was already resolved in CVS. The SetExceptions
    and GetExceptions functions have been renamed to
    GetHostExceptions and SetHostExceptions.

    --angelo

     

Log in to post a comment.