Menu

#626 Player: Compile with local libphidget installation

Unstable
closed-accepted
Player (393)
5
2010-10-12
2010-10-11
No

Current versions of the Phidget libraries do not come with a .pc-file for pkg-config anymore. Presumably, this is also the reason for the two advanced CMake configuration variables PHIDGET_LIB_DIR and PHIDGET_INCLUDE_DIR in Player. Unfortunately, those variables are not handled correctly in cmake/internal/SearchForStuff.cmake - they are checked for being non-empty, but then PHIDGET_DIR is referenced, which is never set and thus always empty.

This patch fixes the cmake file to reference the correct variables. It is against the current SVN revision 8936.

Discussion

  • Jan Schlüter

    Jan Schlüter - 2010-10-11

    Player patch fixing the cmake scripts to correctly handle local libphidget installations.

     
  • Rich Mattes

    Rich Mattes - 2010-10-12
    • status: open --> closed-accepted
     
  • Rich Mattes

    Rich Mattes - 2010-10-12

    The changes have been made in SVN trunk.
    Thank you for your contribution.

     
  • Francois-Michel De Rainville

    It seems that the patch does not enable the build of phidget drivers when dns_sd is not present.

    Removing "AND HAVE_DNS_SD" from the last condition to set HAVE_PHIDGET in SearchForStuff.cmake seems to fix the problem.

     
  • Rich Mattes

    Rich Mattes - 2010-12-11

    Sorry about that, I've fixed it in trunk.

     

Log in to post a comment.