Menu

#5477 FT: Truck and Aircraft computer text missing (regression)

Full Throttle
closed-fixed
kirben
Graphics (902)
5
2010-11-30
2010-10-23
LionsPhil
No

During the finale, some of the interface text for the aircraft and truck computers does not appear. In particular, the truck's flashing "reported as stolen" text is missing, and any of the incorrect options result in a blank (computer) screen rather than error text (for example, most of the aircraft options should report that the system you tried to use is too damaged).

Attaching a ScummVM savegame for this point of the game. Will attach original DOS save for comparison. Click the console in the middle and any of the options other than raising the landing gear. Getting to the truck screen is easy from here: Take Off, Post-Take Off, Gear, Raise, then click on the truck cabin and screen after the cutscene. There try, for example, Defense Menu, Machine Guns, About, which will give the impression of the game locking up as it pauses for several screens of invisible text.

ScummVM 1.2.053093 (Oct 9 2010 11:56:44) running on Win32
Game version "Version B/English" (CD talkie, White Label budget release)

Note that there are previous (fixed) bugs with this text instead overprinting: e.g. 899323.

Discussion

  • LionsPhil

    LionsPhil - 2010-10-23

    ScummVM savegame for aircraft cockpit

     
  • LionsPhil

    LionsPhil - 2010-10-23

    Original DOS interpreter savegame for aircraft cockpit

     
  • LionsPhil

    LionsPhil - 2010-10-23

    Also affects SVN revision 53733, built with MSVC10.

     
  • Jordi Vilalta Prat

    • summary: Truck and Aircraft computer text missing --> FT: Truck and Aircraft computer text missing
     
  • digitall

    digitall - 2010-10-25

    Have tested with previous versions. This has been broken for quite a while.

    The bug was introduced between 0.8.2 and 0.9.0.

    Will bisect for exact point of breakage.

     
  • digitall

    digitall - 2010-10-25

    Note : Can't load the attached ScummVM savegame with any version earlier than v1.2.0
    To replicate, use boot param 930 i.e.
    ./scummvm -b 930 ft
    Then walk to cockpit ladder twice and then use computer...

     
  • digitall

    digitall - 2010-10-25

    This regression was introduced by :
    r19398 | cyx | 2005-11-02 21:47:44 +0000 (Wed, 02 Nov 2005) | 2 lines

    To match the original v7/v8 interpreters, use BlastTexts to display the subtitles. This allows to fix the bug #1092993. As this is quite an important change, regressions may appear. You've been warned :)

     
  • Torbjörn Andersson

    I can reproduce the bug, but it appears to work correctly if I have subtitles enabled - which I almost always do - so hopefully it will be fairly easy to fix.

     
  • Torbjörn Andersson

    It could be as simple as making a small change in ScummEngine_v7::processSubtitleQueue(). Right now, it first checks if subtitles are turned off (or if VAR(VAR_VOICE_MODE) is zero), then it checks (again) if subtitles are turned off and there is a speech version of the message.

    That first test seems a bit aggressive, but I'm not confident enough about it to make any changes.

     
  • kirben

    kirben - 2010-11-30

    I checked the disassembly of FT/DIG/COMI, and the first check doesn't make any sense at all.

    Fixed, by merging the two checks together, to closer match original games.

     
  • kirben

    kirben - 2010-11-30
    • assigned_to: nobody --> kirben
    • summary: FT: Truck and Aircraft computer text missing --> FT: Truck and Aircraft computer text missing (regression)
    • status: open --> closed-fixed