Menu

#4160 SWORD1: palette glitches during scene changes in endgame

Broken Sword 1
closed-fixed
Graphics (902)
2
2009-02-15
2009-02-14
No

In the final scene where the Grand Master restores the broken sword, camera viewpoint changes are accompanied by a brief flash or wrong colours, seemingly a palette change occurring just too early or late.

It may also have happened earlier, but in this scene it was very noticable. Savegame just before the scene attached. Just walk to the rear of the screen.

This is with Gentoo on amd64, English talkie BS1, DXA video, scummvm 0.13 branch from 2009-02-13.

Discussion

  • Willem Jan Palenstijn

    savegame

     
  • Willem Jan Palenstijn

    • priority: 5 --> 2
     
  • Torbjörn Andersson

    Patch against current SVN

     
  • Torbjörn Andersson

    I think the problem is that this is one of the few (perhaps the only) places where the palette is changed immediately, rather than faded. In this particular case, it's probably better to do the palette change in updateScreen() rather than newScreen(). I'm attaching a patch to show what I mean, but there may be some simpler way of doing it. (There's some duplication of code.)
    File Added: bs1-palette.diff

     
  • Willem Jan Palenstijn

    Committed an adapted patch. It works in all the scene changes I tested, but probably needs more testing.

     
  • Willem Jan Palenstijn

    • assigned_to: nobody --> wjpalenstijn
    • status: open --> closed-fixed