Menu ▾ ▴

#1738 LOOM: Cursor hotspot is wrong (regression)

Loom CD/Talkie
closed-fixed
Torbjörn Andersson
Graphics (902)
7
2004-08-24
2004-08-23
Eugene Sandulenko
No

With latest Fingolfin's cursor improvement cursor
hotspot in Loom is
shifted in down-right direction, i.e. intead of (0,0)
it somewhere
around (10,11).

Steps to reproduce:
Start the game and try to point on the leaf.

ScummVM version: CVS Aug 23.

Discussion

  • Eugene Sandulenko

    Eugene Sandulenko - 2004-08-23
    • priority: 5 --> 7
    • assigned_to: nobody --> fingolfin
     

  • Torbjörn Andersson

    Torbjörn Andersson - 2004-08-23

    Logged In: YES
    user_id=577918

    A bug in our "set hotspot" opcode, it seems: it ignores the
    'index' parameter. I've attached a possible patch, but I'm a
    bit uncertain about which games need the three-parameter
    version of setCursorHotspot(), so I'm hesitant to apply it.

     

  • Torbjörn Andersson

    Torbjörn Andersson - 2004-08-23

    Patch against an August 23 CVS snapshot

     
    loom_cursor_fix.diff

  • Max Horn

    Max Horn - 2004-08-23

    Logged In: YES
    user_id=12935

    It should be for all V3-V5 games, I'd say. Those games had 4 basic
    cursor, which could be set via SO_CURSOR_SET; and SO_CURSOR_IMAGE
    / SO_CURSOR_HOTSPOT modified these built-in cursors.
    In newer games, the cursors are far more flexible, so the hotspot/image
    etc. are simply set for the current/active cursor.

     

  • Torbjörn Andersson

    Torbjörn Andersson - 2004-08-24

    Logged In: YES
    user_id=577918

    Ok, I've modified my patch a bit to make it more consistent
    with how the cursor images are redefined, and comitted it.

    Even in a worst case, it shouldn't be able to cause much
    harm. :-)

     

  • Torbjörn Andersson

    Torbjörn Andersson - 2004-08-24
    • assigned_to: fingolfin --> eriktorbjorn
    • status: open --> closed-fixed