Menu
▾
▴
#377 Property macro expansion does not happen for Element types
In element.cs, in the CreateChildBuildElement method,
the parameter "properties" is not used.
Property macro expansion does not happen. In my
build, I have created a custom task which takes a
filename as a parameter
<blah>filename</blah>
but when i use it with a property, its not expanded
<blah>${filename}</blah>
(get "${filename} not found")
Logged In: YES
user_id=707851
Can you send me a repro and provide more information on
the behaviour you were expecting ?
Logged In: YES
user_id=1263750
I've uploaded a test task .cs file [Test2Task.cs].
If you look at, say, this property
[BuildElement("size", Required=true)]
public TextElement Size{...}
When using this in an actual build, if I use a property instead
of a literal in the build file, it is not expanded (it is treated as
a literal).
I would expect it to be expanded (as is the case when I use a
TaskAttribute attribute on a property)
Logged In: YES
user_id=707851
I don't think we should be expanding properties in raw XML.
This is something you can easily take care off yourself using
Project.ExpandProperties.
For the example you attached, you'd need to modify
TextElement.Text to
public string Text
{
get
{
Project.ExpandProperties(this.XmlNode.InnerText,
Location);
}
}