Bugs found via compiler diagnostics

I sent this e-mail to the rdesktop-devel mailing list on October 2, 2008. I got a "waiting for moderator" message from the mailing list software, but the e-mail was never posted.

As of November 14, 2008, all of these bugs are still unfixed.

<original e-mail follows>

To whomever it may concern:

Here is a list of bugs and infelicities turned up in the "rdesktop-1.6.0" source distribution, as of 2008-09-25, when built with extra compiler diagnostics. I'm not able to spend a lot of time contributing to rdesktop, so I'm going to dump them on the mailing list and then get out of the way. Please take care of these issues as you see fit. If they're already known and fixed, I apologize in advance for wasting your time.

BUG - appears to be a serious bug
ERROR - appears to be a serious bug, but is only triggered
on "error" codepaths
COSMETIC - does not appear to affect correctness

"rdesktop.c", line 1274
COSMETIC p is set but not read
"xwin.c", line 641
BUG pointless comparison of unsigned with zero
"xwin.c", lines 2627-2637
ERROR read of uninitialized variables rfds, wfds
"ewmhints.c", lines 499-500
COSMETIC cur_set, new_set are overwritten before being read
"secure.c", line 319
COSMETIC flags set but never read
"secure.c", lines 762-829
ERROR pointer "rdpver" dereferenced after NULL-check;
read of uninitialized variable channel
"licence.c", lines 228-237
ERROR potentially NULL pointer in_token dereferenced
"rdpdr.c", line 1212
COSMETIC iorq set but never read
"serial.c", line 568
COSMETIC integer conversion resulted in a change of sign
"serial.c", line 565
COSMETIC ptermios set but never read
"serial.c", line 714
COSMETIC ptermios set but never read
"disk.c", line 350
COSMETIC handle is overwritten before being read
"disk.c", line 449
COSMETIC integer conversion resulted in a change of sign
"parallel.c", lines 139-146
BUG switch cases must be terminated with break
"parallel.c", line 174
BUG switch cases must be terminated with break
(it's unclear whether the first case is supposed
to fall through into the default case or not)
"mppc.c", line 294
COSMETIC match_len is overwritten before being read