the old detect can't do with:
zh-cn, zh-sg, zh-***
u know, there's so many langs which match "[a-zA-Z]{2}(-[a-
zA-Z]{2})?" in IE
e.g.:
en-gb en-cz zh-cn zh-sg
and the default installtion for ChinaMainlan is "zh-cn", not "zh"
the 1st patch has smaller changes
and 2nd patch is recommed, because it would be better
handled in foreach loop to change regexp so it has "(-[a-zA-Z]
{2})?"
it looks that "zh[-_]tw|.." will be affected, but no, it's fine
because "zh[-_]tw([-_][[:alpha:]]{2})?" still match "zh-tw",
and won't match "zh-cn" or "zh"
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Your change requires languages with two vairant - one
specific (sr-lat) and one generic (sr) to be listed in
specific order, but seems reasonable to me.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
cos there is a "-" for the mark
i think
"(-[[:alpha:]]{2,3})?"
or "(-[[:alpha:]]{2,})?"
or "(-[[:alpha:]]+)?"
all is fine for me, not a serious problem
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
opps~~, very sorry... comment out the cookie is my personal
private "fix", shouldn't be in the patch :(
the cookie is conflict with my own one. IMHO, cookies used
by phpmyadmin should prefix with PMA_, e.g. PMA_lang
but this is another issue. maybe i should open another RFE? :)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
patch 1
alternative patch
Logged In: YES
user_id=192186
What's problem with current detection? Please describe what
is your patch fixing, without such infomation it can not be
applied.
Logged In: YES
user_id=185131
the old detect can't do with:
zh-cn, zh-sg, zh-***
u know, there's so many langs which match "[a-zA-Z]{2}(-[a-
zA-Z]{2})?" in IE
e.g.:
en-gb en-cz zh-cn zh-sg
and the default installtion for ChinaMainlan is "zh-cn", not "zh"
the 1st patch has smaller changes
and 2nd patch is recommed, because it would be better
handled in foreach loop to change regexp so it has "(-[a-zA-Z]
{2})?"
'zh|chinese simplified'
becomes:
'zh([-_][[:alpha:]]{2})?|chinese simplified'
'en|english'
becomes:
'en([-_][[:alpha:]]{2})?|english'
it looks that "zh[-_]tw|.." will be affected, but no, it's fine
because "zh[-_]tw([-_][[:alpha:]]{2})?" still match "zh-tw",
and won't match "zh-cn" or "zh"
Logged In: YES
user_id=192186
Your change requires languages with two vairant - one
specific (sr-lat) and one generic (sr) to be listed in
specific order, but seems reasonable to me.
Logged In: YES
user_id=185131
cos there is a "-" for the mark
i think
"(-[[:alpha:]]{2,3})?"
or "(-[[:alpha:]]{2,})?"
or "(-[[:alpha:]]+)?"
all is fine for me, not a serious problem
Logged In: YES
user_id=192186
And one more question: why did you comment out setting
language from cookie?
Logged In: YES
user_id=185131
opps~~, very sorry... comment out the cookie is my personal
private "fix", shouldn't be in the patch :(
the cookie is conflict with my own one. IMHO, cookies used
by phpmyadmin should prefix with PMA_, e.g. PMA_lang
but this is another issue. maybe i should open another RFE? :)
Logged In: YES
user_id=192186
I made a bit different patch based on yours, can you test
whether it will work okay for you?
About cookie prefix: you're right we use pma prefix on other
places.
updated patch
Logged In: YES
user_id=185131
it's fine :)
Logged In: YES
user_id=192186
Thanks, just commited into cvs.
Logged In: YES
user_id=192186
I just forgot to mention, that I also changed cookie name.