Menu

#357 (ok 2.11) browse table sorted by key \"onChange\"

closed-accepted
1
2007-08-21
2007-04-19
No

since javascript is obligatory anyway there is no need to confirm a sort by key request. On the contrary many other similar select boxes make use of "onChange" submit, e.g., language select... (patch for pma 2.11 attached)

Discussion

  • Jürgen Wind

    Jürgen Wind - 2007-04-19

    Logged In: YES
    user_id=1383652
    Originator: YES

    patch for pma 2.10 added
    File Added: SortByKeyOnChange 2.10.patch

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-19
    • labels: --> Navigation/Usability
     
  • Marc Delisle

    Marc Delisle - 2007-04-20

    Logged In: YES
    user_id=210714
    Originator: NO

    I'm not so sure that javascript is obligatory in phpMyAdmin. I seem to remember that we take (took?) care in ensuring that it works without javascript. If you check libraries/display_select_lang.lib.php, you'il see a <noscript> section that displays a Go button.

    Of course we can add some onchange statements, provided there is an submit button alternative.

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-20

    Logged In: YES
    user_id=1383652
    Originator: YES

    >Of course we can add some onchange statements, provided there is an submit button alternative.
    ok, thats an option, but i thouhgt to remember some statements that using pma without js enabled was useles.

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-20

    Logged In: YES
    user_id=1383652
    Originator: YES

    File Added: SortByKeyOnChange 2.10withNoScript.patch

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-20

    patch with <noscript> option</noscript>

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-20

    new 2.11 patch with< NoScript> option

     
  • Jürgen Wind

    Jürgen Wind - 2007-04-20

    Logged In: YES
    user_id=1383652
    Originator: YES

    <noscript> modified patches attached
    File Added: SortByKeyOnChange 2.11withNoScript.patch

     
  • Marc Delisle

    Marc Delisle - 2007-04-23

    Logged In: YES
    user_id=210714
    Originator: NO

    Merged in subversion, thanks.

     
  • Marc Delisle

    Marc Delisle - 2007-04-23
    • priority: 5 --> 1
    • summary: browse table sorted by key "onChange" --> (ok 2.11) browse table sorted by key "onChange"
    • assigned_to: nobody --> lem9
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2007-08-21
    • summary: (ok 2.11) browse table sorted by key "onChange" --> (ok 2.11) browse table sorted by key \"onChange\"
    • status: open-accepted --> closed-accepted