Menu ▾ ▴

#346 simplified server list on main page.

Finished,_needs_basic_tests
closed-rejected
Marc Delisle
Displaying results (34)
5
2007-02-17
2007-02-08
No

This patch adds the possibility to only show the number/count of databases a server has on the main page (main.php).

It addresses the '@todo', line 73 of libraries/select_server.lib.php.

By default, the old behavior is used, and by a configuration variable, the new behavior is used.

Discussion

  • Anonymous

    Anonymous - 2007-02-08

    diff -u3 of select_server.lib.php and config.default.php

     
    server_list.patch

  • Marc Delisle

    Marc Delisle - 2007-02-11
    • assigned_to: nobody --> lem9
     

  • Marc Delisle

    Marc Delisle - 2007-02-11

    Logged In: YES
    user_id=210714
    Originator: NO

    Bonjour Julien,
    thanks for your patch. However we try to avoid adding a new config variable if possible.

    A suggestion: if the count of $server['only_db'] is > 2, we just skip adding anything to $label. Displaying "4 databases" is not correct IMO because in only_db you can have wildcards.

     

  • Marc Delisle

    Marc Delisle - 2007-02-17

    Logged In: YES
    user_id=210714
    Originator: NO

    Implemented my suggestion in 2.11

     

  • Marc Delisle

    Marc Delisle - 2007-02-17
    • status: open --> closed-rejected