Menu

#1735 (in 2.7.0) JS doesn't working correctly on SQL history

2.6.4-pl2
fixed
1
2013-06-11
2005-07-24
No

When I want to edit (or exec) sql-query from history in
QueryWindow, query-win is refreshed to index.php ...

This is only for multi-line query.

PMA: snapshot 2005-07-24

Thanx.

Discussion

  • Marc Delisle

    Marc Delisle - 2005-07-25
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2005-07-25

    Logged In: YES
    user_id=210714

    Hi,
    is this the same bug as the one your reported ( 1194321 )?

     
  • Marc Delisle

    Marc Delisle - 2005-07-29

    Logged In: YES
    user_id=210714

    Please give me an example of the multi-line query, and which
    browser you are using.

     
  • Marc Delisle

    Marc Delisle - 2005-08-05

    Logged In: YES
    user_id=210714

    Moved to support, waiting for further info.

     
  • jenik kaspar

    jenik kaspar - 2005-08-09

    Logged In: YES
    user_id=749065

    multi-line query (like a):
    SELECT *
    FROM users
    WHERE 1

    - this query is save with \r\n (new line) and print to html code
    with no change -> JS error.

    Tested with Mozilla 1.7 and IE6.

     
  • Marc Delisle

    Marc Delisle - 2005-08-09

    Logged In: YES
    user_id=210714

    Confirmed, also in FF 1.0.6.
    Moved to Bugs.

     
  • Marc Delisle

    Marc Delisle - 2005-08-18
    • assigned_to: lem9 --> nobody
     
  • jenik kaspar

    jenik kaspar - 2005-09-12

    Logged In: YES
    user_id=749065

    this can help:

    replace all preg_ pattern with '/(\r?)\n/i' and change it to
    new JS line
    like:
    ... preg_replace('/(\r?)\n/i', '\\n', [query]) ...
    (file: querywindow.php, lines: 147-148, 170-171, 190-191)

    on Win (server: Apache2 + php5) works fine .. ;)

     
  • Sebastian Mendel

    • assigned_to: nobody --> cybot_tm
    • status: open --> open-accepted
     
  • Sebastian Mendel

    • labels: --> Browser/W3C/JS compatibility
    • milestone: --> 2.6.4-pl2
    • priority: 5 --> 1
    • summary: JS doesn't working correctly on SQL history --> (in 2.7.0) JS doesn't working correctly on SQL history
    • status: open-accepted --> open-fixed
     
  • Michal Čihař

    Michal Čihař - 2005-12-04
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed