Menu

#628 Updated Progress 4GL lexer - Code attached!!

Completed
closed
Scintilla (390)
4
2010-07-30
2009-11-22
Yuval1
No

Improve handling of comments in preprocessor declaration
Cleaning code
Improve documentation

Cheers
Yuval

Discussion

  • Yuval1

    Yuval1 - 2009-11-22

    An updated source

     
  • Neil Hodgson

    Neil Hodgson - 2009-12-12

    Committed.

     
  • Neil Hodgson

    Neil Hodgson - 2009-12-12
    • labels: --> Scintilla
    • milestone: --> Completed
    • priority: 5 --> 4
    • assigned_to: nobody --> nyamatongwe
     
  • Neil Hodgson

    Neil Hodgson - 2010-01-20

    There is some code in here that causes a warning from GCC because the order of evaluation may be wrong since && is higher priority than ||. Braces should be used to ensure intended behaviour.

    if (((sc.state & 0x10) == 0) && keywords2.InList(s) || keywords3.InList(s)) {

    I have changed this to the equivalent

    if ((((sc.state & 0x10) == 0) && keywords2.InList(s)) || keywords3.InList(s)) {

    even though this may not be the intent.

     
  • Neil Hodgson

    Neil Hodgson - 2010-07-30
    • status: open --> closed
     

Log in to post a comment.