Menu
▾
▴
#318 Failing unit tests for the LingoFingerprinter
Rajarshi,
your Lingo FP patch introduced failing unit tests because the AbstractFingerprinter test also tests functionality for unsupported methods.
You/we need to split the AbstractFingerprinterTest into three classes: one with tests for any FPs, one for the new type of FPs (like the LingoFP), and one for the old FPs.
From Supernightly:
Testcase: testBug706786(org.openscience.cdk.fingerprint.LingoFingerprinterTest): Caused an ERROR
null
java.lang.UnsupportedOperationException
at org.openscience.cdk.fingerprint.LingoFingerprinter.getFingerprint(LingoFingerprinter.java:75)
at org.openscience.cdk.fingerprint.AbstractFingerprinterTest.testBug706786(AbstractFingerprinterTest.java:62)
Testcase: testBug853254(org.openscience.cdk.fingerprint.LingoFingerprinterTest): Caused an ERROR
null
java.lang.UnsupportedOperationException
at org.openscience.cdk.fingerprint.LingoFingerprinter.getFingerprint(LingoFingerprinter.java:75)
at org.openscience.cdk.fingerprint.AbstractFingerprinterTest.testBug853254(AbstractFingerprinterTest.java:84)
Testcase: testBug934819(org.openscience.cdk.fingerprint.LingoFingerprinterTest): Caused an ERROR
null
java.lang.UnsupportedOperationException
at org.openscience.cdk.fingerprint.LingoFingerprinter.getFingerprint(LingoFingerprinter.java:75)
at org.openscience.cdk.fingerprint.AbstractFingerprinterTest.testBug934819(AbstractFingerprinterTest.java:108)
Testcase: testBug771485(org.openscience.cdk.fingerprint.LingoFingerprinterTest): Caused an ERROR
null
java.lang.UnsupportedOperationException
at org.openscience.cdk.fingerprint.LingoFingerprinter.getFingerprint(LingoFingerprinter.java:75)
at org.openscience.cdk.fingerprint.AbstractFingerprinterTest.testBug771485(AbstractFingerprinterTest.java:132)
Testcase: testBug931608(org.openscience.cdk.fingerprint.LingoFingerprinterTest): Caused an ERROR
null
java.lang.UnsupportedOperationException
at org.openscience.cdk.fingerprint.LingoFingerprinter.getFingerprint(LingoFingerprinter.java:75)
at org.openscience.cdk.fingerprint.AbstractFingerprinterTest.testBug931608(AbstractFingerprinterTest.java:157)
Patch to fix this bug for master.
Applied and pushed