The Chemistry Development Kit / Patches / #113 Extraction of common unit tests for IFingerprinter

#113 Extraction of common unit tests for IFingerprinter

Milestone: Needs_Revision

Status: closed

Owner: Rajarshi Guha

Labels: None

Branch:

Priority: 5

Updated: 2012-10-08

Created: 2009-10-13

Creator: Egon Willighagen

Private: No

This patch aimed at master, refactors the unit tests for IFingerprinter implementations, providing the unit tests for a few bugs to all implementations.

Rajarshi, you are most familiar with the IFingerprinter code; can you (as a minimum) review the two patches?

Discussion

Egon Willighagen - 2009-10-13

0001-Extracted-an-AbstractFingerprinterTest-with-unit-tes.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2009-10-13

0002-Updated-the-unit-test-classes-for-all-IFingerprinter.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2009-10-13

You will likely notice that a few unit tests are actually failing. This means either the unit test for those bug reports contain bugs, or the IFingerprinter implementation does, IMHO. This needs to be explored separately.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Rajarshi Guha - 2009-10-14

Patches look good. Applied to master and pushed to GitHub

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Extraction of common unit tests for IFingerprinter

Group

Searches

Help

#113 Extraction of common unit tests for IFingerprinter

Discussion