Thanks for the patch. I think the idea is good, but the implementation needs some additional work:
(1) Any change to the state of the PolarPlot should fire a PlotChangeEvent -- this ensures that the plot is redrawn automatically as necessary;
(2) Related to (1), it probably makes sense to make a copy of the list passed into setAngleTicks() -- so that the caller doesn't by-pass the change event mechanism by directly modifying the list that is now under the control of the PolarPlot;
(3) The PolarPlot equals() implementation will need to be updated to check the angleTicks, as will the clone() method.
Regards,
Dave Gilbert
JFreeChart Project Leader
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Copy-paste of added content to PolarChart.java
Logged In: YES
user_id=112975
Originator: NO
Thanks for the patch. I think the idea is good, but the implementation needs some additional work:
(1) Any change to the state of the PolarPlot should fire a PlotChangeEvent -- this ensures that the plot is redrawn automatically as necessary;
(2) Related to (1), it probably makes sense to make a copy of the list passed into setAngleTicks() -- so that the caller doesn't by-pass the change event mechanism by directly modifying the list that is now under the control of the PolarPlot;
(3) The PolarPlot equals() implementation will need to be updated to check the angleTicks, as will the clone() method.
Regards,
Dave Gilbert
JFreeChart Project Leader
Logged In: YES
user_id=112975
Originator: NO
I committed a different patch to Subversion that performs a similar function:
https://sourceforge.net/tracker/index.php?func=detail&aid=1871902&group_id=15494&atid=315494
...so I'll close this one. Thanks for your efforts all the same.
Regards,
Dave Gilbert
JFreeChart Project Leader