Menu ▾ ▴

#320 mark next/prev with peer text widgets

closed-fixed
Jan Nijtmans
18. [text] (26)
7
2012-01-22
2012-01-10
Francois VOGEL
No

The attached patch fixes items 3288113 and 3288121:

Missing marks when searching through mark next from peers:
https://sourceforge.net/tracker/?func=detail&aid=3288113&group_id=12997&atid=112997

Endless loop with mark prev from peer text widget:
https://sourceforge.net/tracker/?func=detail&aid=3288121&group_id=12997&atid=112997

The patch is against the latest Fossil sources.

The existing textMark.test suite passes with no failure.
Plus I have added one test item for each issue above that the patch is fixing.

Discussion

  • Francois VOGEL

    Francois VOGEL - 2012-01-10

    Patch for items 3288113 and 3288121

     
    3288113_3288121_V1.patch

  • Francois VOGEL

    Francois VOGEL - 2012-01-10
    • assigned_to: hobbs --> vincentdarley
     

  • Francois VOGEL

    Francois VOGEL - 2012-01-18
    • assigned_to: vincentdarley --> nijtmans
     

  • Jan Nijtmans

    Jan Nijtmans - 2012-01-19

    Patch applied in branch patch-3471873.

    After adding test textmark-7.9, various tests textmark-8.x started
    failing due to leftover marks, so converted those to new-style
    tktest format and added cleanup code. With this change,
    all tests now pass.

    As far as I can see, everthing is OK to be merged to the
    core-8-5-branch and to trunk.

    François, agreed?

     

  • Francois VOGEL

    Francois VOGEL - 2012-01-19
    • priority: 5 --> 7
     

  • Francois VOGEL

    Francois VOGEL - 2012-01-19

    Sure, please proceed.
    Thanks a lot again for your help!

     

  • Jan Nijtmans

    Jan Nijtmans - 2012-01-22
    • status: open --> closed-fixed
     

  • Jan Nijtmans

    Jan Nijtmans - 2012-01-22

    Merged to trunk and to core-8-5-branch. Everything looks OK to me.

    Thanks! François!