Menu

#1138 agentx debugging fixes

closed
None
5
2012-11-09
2011-06-01
Bill Fenner
No

I did some pretty deep agentx debugging at one point, and found that the indentation was unbalanced. This would result in lines being indented with 10000 spaces (yes, really) by the time I had seen enough packets to cause the bug I was tracking.

I went through agentx/protocol.c and balanced all of the DEBUGINDENTMORE() / DEBUGINDENTLESS() calls. I also added some information to certain debug statements, and got rid of the misleading "agentx/master: unexpected callback op 4" message by handling NETSNMP_CALLBACK_OP_CONNECT explicitly.

Discussion

  • Bill Fenner

    Bill Fenner - 2011-06-01
     
  • Wes Hardaker

    Wes Hardaker - 2011-06-01

    Thanks! I've applied them to the 5.5+ branches. They should go into the 5.3/4 branch too, but they're in last call before a release and debugging fixes probably aren't worthy so I'll apply them after those branches go out of freeze.

     

Log in to post a comment.