Menu

#538 Fix for #1758876: client insensitive after discard

closed-accepted
None
9
2007-08-05
2007-07-26
Bas Wijnen
No

I suppose the problem was in the robber patch, although I don't really see how. Anyway, I've found and fixed it in the attached patch; after rolling a 7, the client goes in "waiting for network" state, and in case a discard was started, it didn't exit from that. I solved this by leaving the state when pushing mode_discard to the stack. This feels a bit wrong, because it is not near the place where the waiting for network state is entered, but it seems the best option.

While testing, I also found that in some cases the client went insensitive after a reconnect. In particular, when you have rolled a 7, and must discard. The problem was that after discard, the client is sent back to previous_state, which was frontend_gui_offline. I've fixed this in the patch as well.

Discussion

  • Bas Wijnen

    Bas Wijnen - 2007-07-26
     
  • Bas Wijnen

    Bas Wijnen - 2007-07-26
    • priority: 5 --> 9
    • assigned_to: nobody --> rclobus
     
  • Roland Clobus

    Roland Clobus - 2007-07-31

    Logged In: YES
    user_id=831677
    Originator: NO

    In a few tests, this patch seems to work.

    I've confirmed that the bug was introduced with the robber patch (try 'svn update -r 1277' and apply the full robber patch).

     
  • Roland Clobus

    Roland Clobus - 2007-07-31
    • assigned_to: rclobus --> shevek
    • status: open --> open-accepted
     
  • Roland Clobus

    Roland Clobus - 2007-08-05

    Logged In: YES
    user_id=831677
    Originator: NO

    Added to svn 1321 (0.11.2)

     
  • Roland Clobus

    Roland Clobus - 2007-08-05
    • status: open-accepted --> closed-accepted
     

Log in to post a comment.