Menu

#391 basic input validation for /*warn and /*drop

closed-accepted
BZFS (98)
3
2007-09-20
2007-02-28
a b c
No

Current /lagwarn sets lagwarn to 0ms when it gets incorrect argument. This patch makes /lagwarn to display a warning message if argument is non-digit, leaving current value unchanged. Also it hadles a trailing space (added if command is issued using autocompleter) in case if no argument was given, making /lagwarn to display current value.

This patch adds this behaviour to /lagdrop, /jitterwarn and /jitterdrop commands as well.

Branch: v2_0branch.
File(s) patched: src/bzfs/commands.cxx

Discussion

  • a b c

    a b c - 2007-02-28
     
  • Joshua Bodine

    Joshua Bodine - 2007-09-20

    Logged In: YES
    user_id=1417147
    Originator: NO

    Applied to trunk (with some modifications for consistency with current code) at r15925. Also fixed behavior for /packetlossdrop and /packetlosswarn.

    Thanks for the patch!

     
  • Joshua Bodine

    Joshua Bodine - 2007-09-20
    • priority: 5 --> 3
    • status: open --> closed-accepted
     
  • Joshua Bodine

    Joshua Bodine - 2007-09-20
    • assigned_to: nobody --> macsforme
     

Log in to post a comment.