Menu

#70 patch:feature request 1574587 -No Undo past file save option

closed-accepted
nobody
5
2007-02-28
2007-02-23
No

Added this as an option on the General Tab of Global Options... This seems to be a more permanent solution than having the user set a macro.

This is coded to the current trunk code.

Let me know of any problems with it (like, it's not wanted would be one).

Discussion

  • Anonymous

    Anonymous - 2007-02-24
    • summary: patch for bug 1574587 - No Undo past file save option --> patch:feature request 1574587 -No Undo past file save option
     
  • Anonymous

    Anonymous - 2007-02-24

    Logged In: YES
    user_id=18174
    Originator: YES

    Sorry. This should say feature request 1574587. Changed it.

     
  • Marcelo Vanzin

    Marcelo Vanzin - 2007-02-27

    Logged In: YES
    user_id=75113
    Originator: NO

    Two comments:

    - any particular reason why you're storing the property both as a jEdit property and as a buffer-local property? It seems to me the second one is not necessary, especially since there's no GUI to change it at the buffer level (and who would do that?).

    - I think the option makes more sense in the "Editing" pane, right below the "max number of undos" option.

    - if it's not asking too much, could you also include an update to the user's guide documenting the option? Thanks!

     
  • Anonymous

    Anonymous - 2007-02-28

    Reset Undo on Save Patch II

     
  • Anonymous

    Anonymous - 2007-02-28

    Logged In: YES
    user_id=18174
    Originator: YES

    That's three comments. :)

    Changes have been made. Sorry about the buffer stuff, I was looking at making it a buffer and global option and then removed the buffer part. I just didn't remove it all the way. My fault.

    I moved it under the editing pane. It seemed, for me, to fit with some of the other options under General, like save marker position and save caret position. I felt that it had more to do with saving than with undo. Also the Editing tab seems to have more to do with the edit mode and the undo stuff looks a little out of place. But it doesn't really go anywhere else either, so editing it is.

    The above also seems to apply to the documentation. When looking at id="undo-redo", it points the user to the "editing-pane", but that section only talks about editing modes and doesn't discuss the undo option at all. I think I'll look at going back there and filling some things in for it, but I think that should be in another patch. For now, I added a very small blurb to the id="undo-redo" section.
    File Added: reset_undo.patch

     
  • Marcelo Vanzin

    Marcelo Vanzin - 2007-02-28
    • status: open --> closed-accepted
     
  • Marcelo Vanzin

    Marcelo Vanzin - 2007-02-28

    Logged In: YES
    user_id=75113
    Originator: NO

    Well, two comments and a request. :-)

    Applied (rev #9037), with a slight modificaton to the method name in JEditBuffer.java.

     

Log in to post a comment.