Menu

#1518 Unused variable warning in tkTextDisp.c

obsolete: 8.5a0
closed-fixed
5
2003-07-07
2003-07-07
No

gcc reports that there is an unused variable in the
function DisplayText in tkTextDisp.c

..../generic/tkTextDisp.c: In function `DisplayText':
..../generic/tkTextDisp.c:2247: warning: unused variable
`flags'

This sort of thing often indicates some kind of problem,
but is sometimes just an indication that there's a
variable that is now simply surplus to requirements due
to code changes (or even an accidental check-in!)

Discussion

  • Jeffrey Hobbs

    Jeffrey Hobbs - 2003-07-07

    Logged In: YES
    user_id=72656

    This does indicate an error. The flags is not used properly.
    The best solution is to move the Release into the if and after
    the if and remove the use of the cached tkwin and flags
    altogether.

     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2003-07-07
    • status: open --> closed-fixed
     
  • Jeffrey Hobbs

    Jeffrey Hobbs - 2003-07-07

    Logged In: YES
    user_id=72656

    fixed for 8.5, not backported as this code was changed for
    8.5 on 2003-05-27.