Menu

#2433 man2tcl does not honor quotes in macro arguments ->bind.n

obsolete: 8.5.2
closed-fixed
5
2008-06-28
2008-04-04
No

with the build target winhelp of makefile.vc, the help application man2tcl.c is build, which processes all files in the doc folder.

An error in macro expansion in man2help2.tcl is invoked when processing bind.n.

The problem:
Quotes in macro arguemnt are not honored. Thus a space within quotes starts a new parameter.

Input sequence:

.ta \w'\fBButtonPress, Button\0\0\0\fR'u +\w'\fBKeyPress, Key\0\0\0\fR'u

Current output:
macro ta \\w'\\fBButtonPress, Button\ \ \ \\fR'u +\\w'\\fBKeyPress, Key\ \ \
Desired output:
macro ta \\w'\\fBButtonPress,\ Button\ \ \ \\fR'u +\\w'\\fBKeyPress,\ Key\ \ \

A patch is attached (not including patch of Tcl Bug 1934200).
To finally process the row correctly, man2help2.tcl also needs a patch, which is supplied in a following bug report.

The files are in the Tcl 8.5.2 sources folder tools.
The error arises when compiling Tk 8.5.2

Discussion

  • Harald Oehlmann

    Harald Oehlmann - 2008-04-04

    tool/man2tcl.c in tcl8.5.2

     
  • Don Porter

    Don Porter - 2008-04-04
    • assigned_to: mdejong --> dkf
     
  • Joe Mistachkin

    Joe Mistachkin - 2008-06-13
    • assigned_to: dkf --> mistachkin
    • status: open --> pending-fixed
     
  • Joe Mistachkin

    Joe Mistachkin - 2008-06-13

    Logged In: YES
    user_id=113501
    Originator: NO

    The new output seems to match the desired output above; however, I'm not 100% convinced this is fixed. Please confirm.

     
  • SourceForge Robot

    • status: pending-fixed --> closed-fixed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539
    Originator: NO

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • Harald Oehlmann

    Harald Oehlmann - 2008-06-30

    Logged In: YES
    user_id=444601
    Originator: YES

    This is solved for me in the head. Backport to 8.5.x would be helpful and easy because the files did not change.