Menu

#2699 tclThreadAlloc.c fails to build on Windows

obsolete: 8.5a2
closed-fixed
5
2004-04-30
2004-04-30
No

When building with Windows 2000/cygwin/VC++,
with configure options --enable-symbols --enable-threads,
tclThreadAlloc.c fails to compile.

The culprit appears to be the recent "header reform"
changes. It appears that this file needs a kludge
similar to the one in tclIOUtil.c to make it compile.

Patch attached.

Discussion

  • Kevin B KENNY

    Kevin B KENNY - 2004-04-30

    Patch for tclThreadAlloc.c

     
  • Kevin B KENNY

    Kevin B KENNY - 2004-04-30

    Logged In: YES
    user_id=99768

    Error messages from compilation attached

     
  • Don Porter

    Don Porter - 2004-04-30
    • assigned_to: dgp --> kennykb
     
  • Don Porter

    Don Porter - 2004-04-30

    Logged In: YES
    user_id=80530

    looks effective but kludgy.

     
  • Kevin B KENNY

    Kevin B KENNY - 2004-04-30

    Errors from compilation

     
  • Don Porter

    Don Porter - 2004-04-30

    Logged In: YES
    user_id=80530

    Here's an alternative patch
    that seems cleaner to me.
    Does it work?

     
  • Don Porter

    Don Porter - 2004-04-30
     
  • Kevin B KENNY

    Kevin B KENNY - 2004-04-30

    Logged In: YES
    user_id=99768

    Don's alternative patch appears to work on
    Win2k/cygwin/VC++ both with and without
    --enable-threads.

     
  • Kevin B KENNY

    Kevin B KENNY - 2004-04-30
    • assigned_to: kennykb --> dgp
     
  • Don Porter

    Don Porter - 2004-04-30
    • status: open --> closed-fixed
     
  • Don Porter

    Don Porter - 2004-04-30

    Logged In: YES
    user_id=80530

    Alternative patch committed.