Menu

#3237 compiler warnings

obsolete: 8.5a4
closed-fixed
5
2005-10-05
2005-09-09
Don Porter
No

"../unix/../generic/tclIORChan.c", line 1052: warning:
statement not reached
"../unix/../generic/tclIORChan.c", line 1841: warning:
no explicit type given for parameter: mask

Discussion

  • Andreas Kupries

    Andreas Kupries - 2005-09-09

    Logged In: YES
    user_id=75003

    Ok, I fixed the second warning.

    The first warning is for

    --------------------
    return (res == TCL_OK) ? EOK : EINVAL;
    }

    Tcl_Panic ("Should not be reached");
    return EINVAL;
    }
    --------------------

    I.e. the panic cannot be reached under normal circumstances.
    I believe to remember that some compilers throw a warning if
    there is no code in this path, i.e. they are not able to
    detect that all paths returned before coming to this place.
    I may be wrong.

    Do we have a policy for this situation ?

     
  • Andreas Kupries

    Andreas Kupries - 2005-10-05

    Logged In: YES
    user_id=75003

    Removed unreachable statements.

     
  • Andreas Kupries

    Andreas Kupries - 2005-10-05
    • status: open --> closed-fixed