Menu ▾ ▴

#36 Printf format %n not supported in latest VS versions

closed-fixed
Kimmo Varis
None
5
2009-02-27
2009-02-27
Kimmo Varis
No

Current SVN trunk, 1.4.0 stable.

If Frhed is compiled with VS 2005 or VS 2008 the executable does not work correctly in some places and either jams or crashes.

The reason is that printf (and friends) format specifier %n is disabled from latest runtime versions as it is unsecure to use.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2009-02-27

    The patch

     
    Remove_percent_n_formatter.patch

  • Kimmo Varis

    Kimmo Varis - 2009-02-27
    • assigned_to: nobody --> kimmov
     

  • Kimmo Varis

    Kimmo Varis - 2009-02-27

    Attaching a patch to remove %n from the code. Luckily it was found only from Compare dialog.
    File Added: Remove_percent_n_formatter.patch

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-27

    Committed to SVN trunk:
    Completed: At revision: 398

    Committed to 1.4 branch:
    Completed: At revision: 399

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-27
    • status: open --> closed-fixed