Menu ▾ ▴

#32 Incorrect shortcut to help file (v1.3.10)

closed-fixed
Kimmo Varis
Installer (1)
5
2009-02-03
2009-02-01
M. Buecher
No

The installer creates a non-working shortcut in the start menu for the help file.
Reason is that the file is in the subfolder DOCS, which is missing in the shortcut target path.
The working path is correctly pointing to the DOCS subfolder.

Discussion

  • Kimmo Varis

    Kimmo Varis - 2009-02-02

    Thanks for reporting! I'll look at this in a moment.

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-02
    • assigned_to: nobody --> kimmov
     

  • Kimmo Varis

    Kimmo Varis - 2009-02-02

    Ok, this patch fixes the bug:

    Index: Installer/NSIS/frhed.nsi

    --- Installer/NSIS/frhed.nsi (revision 357)
    +++ Installer/NSIS/frhed.nsi (working copy)
    @@ -90,7 +90,7 @@
    Section "Documentation" SEC02
    SetOutPath "$INSTDIR\Docs"
    File "..\..\Build\Manual\htmlhelp\frhed.chm"
    - CreateShortCut "$SMPROGRAMS\Frhed\Help.lnk" "$INSTDIR\frhed.chm"
    + CreateShortCut "$SMPROGRAMS\Frhed\Help.lnk" "$INSTDIR\Docs\frhed.chm"
    SectionEnd

    Section -AdditionalIcons

    File Added: Fix_manual_shortcut.patch

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-02

    The patch

     
    Fix_manual_shortcut.patch

  • Kimmo Varis

    Kimmo Varis - 2009-02-02

    Committed the fix to SVN trunk:
    Completed: At revision: 361

    Will commit to 1.4 branch later.

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-02
    • status: open --> open-fixed
     

  • Kimmo Varis

    Kimmo Varis - 2009-02-03

    Fix committed to 1.4 branch and will be in 1.4 stable release in few days.

    Completed: At revision: 362

     

  • Kimmo Varis

    Kimmo Varis - 2009-02-03
    • status: open-fixed --> closed-fixed