Menu

#29 dispatcher probe asterisk

trunk
closed-fixed
modules (179)
5
2009-02-10
2008-10-16
No

Asterisk responds with a 404 to Options requests with no user part, which is what the dispatcher probe builds, 404 shows that UA is up and talking sip, so it should be sufficient to pass the probe. Patch adds 404 status code as a successful result to the probe.

Discussion

  • Bogdan-Andrei Iancu

    • assigned_to: nobody --> bogdan_iancu
     
  • Bogdan-Andrei Iancu

    Hi Kevin,

    I do not like this approach with keep adding a build in list to cover all the possibilities for whatsoever device - I'm would rather go for a different approach: default only 200 OK means re-active and you can configure (module params) a list of custom codes to be considered for re-activation.
    In this way, everybody will be able to set his own codes without polluting the code itself.

    Regards,
    Bogdan

     
  • Kevin McAllister

    Hi Bogdan,

    Sounds like a much better approach. I'll consider spending time submitting such a patch in the next week if I can find time. This will be much easier for me in the long run if it's configurable.

    Thanks for taking the time to review and respond.

     
  • Olle E. Johansson

    With proper configuration, Asterisk will answer 200 OK.

    Just add the "s" extension in the proper context.

     
  • Bogdan-Andrei Iancu

    Anca will implement configurable set of reply codes to be considered as "successful" probe.

    Bogdan

     
  • Bogdan-Andrei Iancu

    • assigned_to: bogdan_iancu --> anca_vamanu
     
  • Anca Vamanu

    Anca Vamanu - 2009-02-10

    Hi,

    I have added a module parameter 'options_reply_codes' that can be set to a list of valid OPTIONS reply codes separated by comma.
    200 is considered valid by default.
    Example:
    modparam("dispatcher", "options_reply_codes", "403, 501, 404")

    regards,
    Anca

     
  • Anca Vamanu

    Anca Vamanu - 2009-02-10
    • status: open --> closed-fixed
     
  • Bogdan-Andrei Iancu

    Anca will implement configurable set of reply codes to be considered as "successful" probe.

    Bogdan

     
  • Bogdan-Andrei Iancu

    • status: closed-fixed --> open-fixed
     
  • Bogdan-Andrei Iancu

    • status: open-fixed --> open
     
  • Bogdan-Andrei Iancu

    Sorry - browser refresh error :D..

     
  • Bogdan-Andrei Iancu

    • status: open --> closed-fixed
     

Log in to post a comment.