Menu
▾
▴
#432 no more audio preview progress dialogs on file load
From the Manage Audio Files dialog I added a gigantic .wav
by mistake. It took forever to generate the preview (it was
a 40 minute file) and I couldn't cancel it.
It's also worth noting that at the end of this process, my
load average spiked at 33-something. I thought the sky
was falling for a minute or two, but it passed quickly, and
the trouble was over.
I'm thinking in retrospect maybe it wasn't a memory leak
after all, but just the normal process of allocating tons of it
while generating this preview. All the more reason the
damn cancel button should work. Bah humbug.
Logged In: YES
user_id=28396
At least partially fixed. You can cancel preview generation
when adding
audio files in the AudioManagerDialog.
However, when loading an RG file with audio files as part of
it RG will also attempt to autogenerate previews for all
audio files that don't already have them. As part of this
operation the cancel is only partially working currently -
the dialog disappears and the preview generation for that
file is skipped but subsequent preview generation will still
occur without any progress dialog. This should be sorted
out as part of this BR.
Logged In: YES
user_id=663564
OK, I'll leave it open then.
Logged In: YES
user_id=663564
I loaded a file with a huge number of audio segments, and some huge
audio files, and the GUI was tied up for a long time doing all the
previews. There was no visible indication that anything was
happening, and it wasn't until I spied this old bug report that I realized
there used to be a progress dialog to let people know what was taking
so long. I think it's gone now. Or else it isn't working. That's part of
the problem. It's kind of rude to use 100% CPU for two minutes and
tie up the GUI without giving any hint that RG is actually doing
something. It leads less experienced people to hit the reset button.
Logged In: YES
user_id=4816
Looking at the code it seems I start a 'generate audio preview'
thread for all audio segments in a row, without waiting for any of
them to stop first. This is bound to overload the cpu. :-(
Logged In: YES
user_id=663564
That's probably the culprit then. This doc has something like 250 audio
segments I think. 250 generate preview threads all running at the
same time? That explains a lot.
Probably still needs some progress indication too, I'd say, because
running 250 of these serially is still going to take some time.
I have some longer thoughts on this, but I'll take them to rg-devel.
Logged In: YES
user_id=663564
Yeah, this all seems fine now. I loaded a huge file and
cancelled it in the middle, no problem. I don't see any
real issues loading Zynfidel either. I think this is all
cured, and I should have closed this months ago.