Menu

#2873 Incremental search bar shows clipboard not selection

normal bug
closed-fixed
5
2008-04-20
2007-05-24
kelby
No

Jedit version 4.3 pre9
Java 1.5.0_06
Operating System: Windows 2000

If I have a selection and then invoke the Incremental search bar (C+comma)the search string field is my clipboard from last copy or cut command.

A normal find seem to work okay, ie if I invoke the Find command (C+F) with a selection the search string field is the selection, not the clipboard.

The user guide states:

Search>Incremental Search Bar (shortcut: C+COMMA) displays the search bar if necessary, and gives it keyboard focus. If this command is invoked while there is a selection, the selection is placed in the search string field.

Discussion

  • Robert Schwenn

    Robert Schwenn - 2008-02-05

    Logged In: YES
    user_id=1486645
    Originator: NO

    This is still an issue.

    When invoking the incremental search (not "for word") while there is a selection, the selection *never* appears as the search text. Instead, somtimes the text from the clipboard is placed in the search string field, sometimes it is empty.

    jEdit version 4.3pre12
    SUN JRE 1.6.0_03
    Windows XP SP2

     
  • n13e144

    n13e144 - 2008-02-14

    Logged In: YES
    user_id=1768417
    Originator: NO

    I don't know what the originally intended behavior was. But the more intuitive behavior, imho, would be for Ctrl-comma (Cmd-comma on Mac) to simply display the Search Bar without affecting the current search string, and for Alt-comma (Ctrl-comma on Mac) to display the Search Bar AND, in addition, to change the search string to the selected text. Indeed, the method responsible, quickIncrementalSearch() in the View class, looks to have been coded this way.

    Given the above, I would just change the docs instead of the functionality. Something like this:

    Search>Incremental Search Bar (shortcut: C+COMMA) displays the search bar if necessary, and gives it keyboard focus.

    Search>Incremental Search for Word (shortcut: A+COMMA) behaves like the above command except that: 1) if this command is invoked while there is a selection, the selection is placed in the search string field; or 2) if there is no selection, it places the word at the caret in the search string field.

    -----------------
    jEdit 4.3pre13
    Java 1.5.0_13
    Mac OS X 10.5.1

     
  • Alan Ezust

    Alan Ezust - 2008-02-14
    • assigned_to: nobody --> ezust
     
  • Matthieu Casanova

    • status: open --> closed-fixed
     
  • Matthieu Casanova

    Logged In: YES
    user_id=285591
    Originator: NO

    It doesn't happens anymore

     
  • Alan Ezust

    Alan Ezust - 2008-04-20
    • status: closed-fixed --> open
     
  • Alan Ezust

    Alan Ezust - 2008-04-20

    Logged In: YES
    user_id=935841
    Originator: NO

    This ticket is still open.

     
  • Alan Ezust

    Alan Ezust - 2008-04-20
    • status: open --> closed-fixed
     
  • Alan Ezust

    Alan Ezust - 2008-04-20

    Logged In: YES
    user_id=935841
    Originator: NO

    I updated the documentation to reflect the current behavior.

    <para><guimenu>Search</guimenu>&gt;<guimenuitem>Incremental Search
    Bar</guimenuitem> (shortcut: <keycap>C+COMMA</keycap>) displays the
    search bar if necessary, and gives it keyboard focus. </para>

    <para><guimenu>Search</guimenu>&gt;<guimenuitem>Incremental Search
    for Word</guimenuitem> (shortcut: <keycap>A+COMMA</keycap>) behaves
    like the above command except it places the word at the caret in the
    search string field. If this command is invoked while there is a
    selection, the selection is placed in the search string
    field instead.</para>

     

Log in to post a comment.