Thank you both for the comments :
just to ensure that I am starting with correct first steps I will mention the steps I followed after your comments.
- First I 'git checkout' ed all the files I did the ./ --> ../
- Instead of sample config used /pma-root/setup/frames/config.inc.php. Is this the correct one to edit? (If we can add this full path in the "Unit Testing" part of the wiki it will help new comers I think)
Your thoughts?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
> - First I 'git checkout' ed all the files I did the ./ --> ../
That would be a way to undo those changes.
> - Instead of sample config used /pma-root/setup/frames/config.inc.php. Is
this the correct one to edit?
No, these setting are not relevant for normal users.
I think they should be located alongside the tests. We could place a test/config.sample.inc.php in Git and let users copy this file to test/config.inc.php in their own checkout. Git can be instructed to ignore the copied file.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Initial fix for failing unit tests.
I had a look at the patch, it does a bit too much.
You added "../" on many include/require lines, which completely breaks the rest of pma.
For tests there are some calls to chdir() to the pma root dir. It might work for you because of a missing chdir statement.
Please try to solve this chdir()'ing to the correct dirctory.
Also changing example configuration looks like a bad idea to me. It should contain only bits, which user might be interested to change.
Thank you both for the comments :
just to ensure that I am starting with correct first steps I will mention the steps I followed after your comments.
- First I 'git checkout' ed all the files I did the ./ --> ../
- Instead of sample config used /pma-root/setup/frames/config.inc.php. Is this the correct one to edit? (If we can add this full path in the "Unit Testing" part of the wiki it will help new comers I think)
Your thoughts?
> - First I 'git checkout' ed all the files I did the ./ --> ../
That would be a way to undo those changes.
> - Instead of sample config used /pma-root/setup/frames/config.inc.php. Is
this the correct one to edit?
No, these setting are not relevant for normal users.
I think they should be located alongside the tests. We could place a test/config.sample.inc.php in Git and let users copy this file to test/config.inc.php in their own checkout. Git can be instructed to ignore the copied file.