Menu

#585 Fixing failing unit tests

closed-invalid
nobody
None
5
2013-01-18
2011-02-10
Kasun L.
No

Here is the initial patch for bug ID: 3170421. Still there are failing tests and I tried to get them work. Can you please check and add your comments?

Discussion

  • Kasun L.

    Kasun L. - 2011-02-10

    Initial fix for failing unit tests.

     
  • Herman van Rink

    Herman van Rink - 2011-02-16

    I had a look at the patch, it does a bit too much.

    You added "../" on many include/require lines, which completely breaks the rest of pma.

    For tests there are some calls to chdir() to the pma root dir. It might work for you because of a missing chdir statement.

    Please try to solve this chdir()'ing to the correct dirctory.

     
  • Michal Čihař

    Michal Čihař - 2011-02-17

    Also changing example configuration looks like a bad idea to me. It should contain only bits, which user might be interested to change.

     
  • Kasun L.

    Kasun L. - 2011-02-18

    Thank you both for the comments :
    just to ensure that I am starting with correct first steps I will mention the steps I followed after your comments.
    - First I 'git checkout' ed all the files I did the ./ --> ../
    - Instead of sample config used /pma-root/setup/frames/config.inc.php. Is this the correct one to edit? (If we can add this full path in the "Unit Testing" part of the wiki it will help new comers I think)

    Your thoughts?

     
  • Herman van Rink

    Herman van Rink - 2011-02-18

    > - First I 'git checkout' ed all the files I did the ./ --> ../

    That would be a way to undo those changes.

    > - Instead of sample config used /pma-root/setup/frames/config.inc.php. Is
    this the correct one to edit?

    No, these setting are not relevant for normal users.
    I think they should be located alongside the tests. We could place a test/config.sample.inc.php in Git and let users copy this file to test/config.inc.php in their own checkout. Git can be instructed to ignore the copied file.

     
  • Marc Delisle

    Marc Delisle - 2011-11-10
    • status: open --> pending
     
  • Marc Delisle

    Marc Delisle - 2013-01-18
    • status: pending --> closed-invalid
    • milestone: --> Basic_idea,_not_for_release