Scintilla / Bugs / #916 HotSpotRange clearing.

#916 HotSpotRange clearing.

Milestone: Bug

Status: closed-fixed

Owner: Neil Hodgson

Labels: Scintilla (812)

Priority: 4

Updated: 2010-04-06

Created: 2010-02-13

Creator: Thell Fowler

Private: No

SetHotSpotRange is not called when mouse exits HotSpotRange outside of client or to margin. The patch simply adds a SetHotSpotRange(NULL) call for both cases. Since SetHotSpotRange does a check prior to doing any clearing of the hotspot no additional checks have been added.

To see an example of this bug a few pics can be viewed in the first post of this thread::
http://nppcommunity.lighthouseapp.com/projects/38932/tickets/16-bug-sticky-hotspot-style

Thanks! And have a great day.

Discussion

Thell Fowler - 2010-02-13

git generated patch

0001-SciLexer-clear-hotspot-style-when-mouse-leaves-hotsp.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2010-02-14

The patch doesn't really line up with current CVS so I have to
guess where the chunks are applied. The first chunk drops the hot spot
when the mouse moves over the margin. This is OK.

The second patch appears to change the hot spot in the WM_SETCURSOR
handler. The only thing that should happen in WM_SETCURSOR is setting
the cursor. This functionality belongs in ButtonMove so that it is
cross-platform with possibly a TrackMouseEvent/WM_MOUSELEAVE or Tick
handler to detect movement outside the window.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2010-02-14

priority: 5 --> 4

assigned_to: nobody --> nyamatongwe

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Thell Fowler - 2010-02-16

git generated patch v2

0001-SciLexer-clear-hotspot-style-when-mouse-leaves-hotsp.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2010-02-19

Fix committed to CVS. This makes use of the Windows TrackMouseEvent function.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2010-02-19

status: open-accepted --> open-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Neil Hodgson - 2010-04-06

status: open-fixed --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.