This my first patche to GSoC, it's a simple patche, add obj-reader
command.
It reads an .obj file and show all object faces. (use: obj-reader
[fileName.obj] >> [fileOut.txt])
Alexandre, I've just finished reviewing this patch and unfortunately it cannot be applied as it is without several modifications. It's a great feature, though, and I do hope that you continue working on it. Had you come forward a little earlier in the submission process, this probably could have even been cleaned up suitably for GSoC too. If you're eligible to participate again later, I'd highly recommend getting more involved earlier on and communicating with the other project developers.
That said, back to the matter of the patch, the biggest problem is that it doesn't actually tie into any of BRL-CAD's data structure but is essentially a standalone file parser that looks for 'v' lines from an obj file.
Another issue is that the patch itself is malformed. You should take care to review the contents of your patch before submitting them to make sure unintentional changes are not included. In yours, for example, there was an object file and edits to unrelated files (g-obj.c).
Another issue is that the patch doesn't conform to our HACKING file developer guidelines. Most open source projects have specific style requirements that you should be attentive to (such as indentation style, comments, and naming conventions).
Finally, with regards to the code operation, the implementation you have for storing faces is horribly inefficient. There is an O(N^2) algorithm being used in insereObj() where you scan to the end of a list for every insertion. Even "small" OBJ model files will take exponentially longer to parse. On of my test cases had just 200k faces and I had to abort it after a half-hour.
If you do continue to work on this, please speak up on the IRC channel and/or brlcad-devel mailing list. Having a obj-g importer would be a fantastic addition to the package and would undoubtedly give you a lot of experience with open source software development. Hope to see you continue this work and thanks again!
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Alexandre, I've just finished reviewing this patch and unfortunately it cannot be applied as it is without several modifications. It's a great feature, though, and I do hope that you continue working on it. Had you come forward a little earlier in the submission process, this probably could have even been cleaned up suitably for GSoC too. If you're eligible to participate again later, I'd highly recommend getting more involved earlier on and communicating with the other project developers.
That said, back to the matter of the patch, the biggest problem is that it doesn't actually tie into any of BRL-CAD's data structure but is essentially a standalone file parser that looks for 'v' lines from an obj file.
Another issue is that the patch itself is malformed. You should take care to review the contents of your patch before submitting them to make sure unintentional changes are not included. In yours, for example, there was an object file and edits to unrelated files (g-obj.c).
Another issue is that the patch doesn't conform to our HACKING file developer guidelines. Most open source projects have specific style requirements that you should be attentive to (such as indentation style, comments, and naming conventions).
Finally, with regards to the code operation, the implementation you have for storing faces is horribly inefficient. There is an O(N^2) algorithm being used in insereObj() where you scan to the end of a list for every insertion. Even "small" OBJ model files will take exponentially longer to parse. On of my test cases had just 200k faces and I had to abort it after a half-hour.
If you do continue to work on this, please speak up on the IRC channel and/or brlcad-devel mailing list. Having a obj-g importer would be a fantastic addition to the package and would undoubtedly give you a lot of experience with open source software development. Hope to see you continue this work and thanks again!
This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).