Menu

#24 WARNX misuse in LoadCursor & LoadIcon

unspecified
closed
5
2012-09-27
2007-08-28
M. Virovets
No

Parameter "condition" in WARNX macro is used vice versa in
TModule::LoadCursor - module.cpp(872) and
TModule::LoadIcon - module.cpp(909).
Moreover, line with CHECKX macro should be placed just before return (IMHO).

Discussion

  • Ognyan Chernokozhev

    Logged In: YES
    user_id=873706
    Originator: NO

    Thanks for finding this, will be included in the next patch

     
  • Sebastian Ledesma

    'HBITMAP TModule::LoadBitmap(TResId id) const' should also move the CHECKX(...); to just before the return.

    'HACCEL TModule::LoadAccelerators(TResId id) const': uses a WARNX instead (just before the return), we should use a CHECKX to keep consistence (or change all CHECKX to WARNX).

     
  • Sebastian Ledesma

    Fixed in 6.21.9 / 6.30

     
  • Sebastian Ledesma

    Solved in 6.21.9 / 6.30.

     

Log in to post a comment.