Menu

#6174 TONY: German Version Not Detected Correctly

Tony Tough
closed-fixed
nobody
5
2013-06-11
2012-11-01
codemarvin
No

The Tony Tough German "Shoe Box" version is not detected in ScummVM version

ScummVM 1.6.0git2034-gfdc80fd-dirty (Oct 31 2012 19:58:56)
Features compiled in: TAINTED Vorbis FLAC ALSA SEQ TiMidity RGB zLib Theora AAC FreeType2

My machine is
Linux ... 2.6.34.10-0.6-default #1 SMP ... i686 i686 i386 GNU/Linux

My temporary fix for proper detection was to change engines/tony/detection_tables.h:
add data1.cab entry and comment out the original two checksums.

{
// Tony Tough German "Shoe Box" provided by Strangerke
{
"tony",
0,
{
{"data1.cab", 0, "f0e939963e14c0e73fd0a87d6d723526", 4346},
/* {"roasted.mpr", 0, "06203dbbc85fdd1e6dc8fc211c1a6207", 135911071},
{"roasted.mpc", 0, "ccf7ab939a34de1b13df538596431684", 389554}, */
AD_LISTEND
},
Common::DE_DEU,
Common::kPlatformWindows,
ADGF_NO_FLAGS,
GUIO1(GUIO_NONE)
},
},

Discussion

  • digitall

    digitall - 2012-11-01
    • summary: TONY: Error in detecting checksum --> TONY: German Version Not Detected Correctly
     
  • digitall

    digitall - 2012-11-01

    codemarvin: Thank you for reporting this bug. It is known that detection of various Tony versions could be problematic i.e. See http://wiki.scummvm.org/index.php/Tony/TODO.

    However, could you please provide a file listing of your version with MD5sums to help us eliminate datafile variance or corruption... This guide should help: http://wiki.scummvm.org/index.php/Reporting_unknown_MD5_checksums

    A file of detection i.e. limited size MD5sums would be useful in addition to normal full file MD5sums.

     
  • codemarvin

    codemarvin - 2012-11-02

    German "Shoe Box" version of Tony, MD5 sums with limit of 5000 chars

     
  • codemarvin

    codemarvin - 2012-11-02

    German "Shoe Box" version of Tony, full MD5 sums

     
  • codemarvin

    codemarvin - 2012-11-02

    Hi tdhs, please find attached two lists of sums for all files in my ScummVM Tony folder - as you requested.

     
  • digitall

    digitall - 2012-11-03

    codemarvin: Thank you for the prompt reply. That should be sufficient to investigate and fix this. Please be patient and standby.

     
  • digitall

    digitall - 2012-11-03

    codemarvin: Could you please confirm the size in bytes of the following files please:
    roasted.mpr, roasted.mpc and data1.cab

     
  • codemarvin

    codemarvin - 2012-11-03

    File sizes in bytes are:

    data1.cab 4346
    roasted.mpc 389554
    roasted.mpr 135911071

     
  • digitall

    digitall - 2012-11-07

    codemarvin: Thank you for the information which should now be sufficient.

    It will take a little time to work out the problem and this may require expanding the entries for other variants to avoid detection collisions, which means getting this kind of information from other users so tl;dr: Please be patient and standby.

     
  • Filippos Karapetis

    • milestone: 152770 --> Tony Tough
     
  • Strangerke

    Strangerke - 2013-06-11
    • status: open --> closed-fixed
     
  • Strangerke

    Strangerke - 2013-06-11

    I added back the detection of MPR/MPC files so that installed games are running properly

     
  • Strangerke

    Strangerke - 2013-06-11

    Added another detection too