Menu

#1371 (ok 4.0) Inline editing by double click

fixed
1
2013-06-11
2012-04-27
arcadius
No

Currently (pma 3.5.0) grid editing in browse mode is started on click.
This can be annoying for some users, f.e., they fear important table data can be accidentally damaged.
Another bad thing is unexpected starting edit mode when trying to select some text in grid (to copy it to clipboard).

It would be good to support 3 configuration modes of Grid editing:
- On click (current behavior),
- On double click,
- Disable.

While there's no this useful setting, I replaced in /js/makegrid.js:
$(g).find("td.data").click
.. with:
$(g).find("td.data").dblclick

Discussion

  • arcadius

    arcadius - 2012-04-27

    Usual action on double click is selecting all text, on 3-click – selecting all line...
    So ideal shortcut for starting inline editing would be Ctrl+Click, if it possible.

     
  • Esa Ristilä

    Esa Ristilä - 2012-05-04

    Make the grid editing altogether optional. I use double-clicking all the time to select text to copy and find the grid editing annoying so it would be great to disable it.

     
  • Naveen Nayak

    Naveen Nayak - 2012-05-25

    I really support the views expressed here -

    1. the inline edit has been really annoying and is very dangerous - most non DBA's who use phpmyadmin try to copy a field and have accidentally changed the values of those fields

    2. another annoying thing about the ui is the "arrange columns by dragging" - it creates a problem when trying to copy column names
    if you really want to implement this feature, you can move it to the "structure" page and allow horizontal drag with an icon - very simple and intuitive

    Ajax is cool - but usability must not be sacrificed for the sake of making the application look cool.

    After switching to 3.5.1 i was so annoyed that i have started looking elsewhere ( like MySQL Workbench )

    I really like phpmyadmin and really appreciate the amount of work you guys do to make it all come together - i am hoping that you will keep the simplistic, user friendly and rich user interface instead of some annoying things like the ones i have mentioned

     
  • Marc Delisle

    Marc Delisle - 2012-05-25

    About #2, it's not a good idea to move it to the Structure page, as this would make a user believe that this permits to change the structure itself, which is not the case (and has been implemented for version 4.0 in another way).

     
  • Matt

    Matt - 2012-08-30

    While I generally like Ajax enable web apps, the in-line editing is one of the most dangerous features I have seen in a long time. It violates the #1 GUI principle which is you don't surprise the user. Clicking on some text in a table should not cause some sort of mode change where you can accidentally change data. This is almost a show-stopper for me that would cause me to downgrade phpMyAdmin or switch to something else, it is just too dangerous to have on a production server.

    I did disable Ajax globally with $cfg['AjaxEnable']=0 but it seems kind of harsh since the other features are OK. I might hack the makegrid.js, that sounds a little better though, thanks for the hint.

    There are several much better alternatives I've already seen, such as double clicking to enable the inline edit box, or control-click, shift-click, maybe even a teeny icon to click, something other than a single click. Please!

    Please upgrade the priority of this request, since it could almost be classified as a bug.

     
  • Anonymous

    Anonymous - 2012-09-28

    yes i want...
    It would be good to support 3 configuration modes of Grid editing:
    - On click (current behavior),
    - On double click,
    - Disable.

     

    Last edit: Anonymous 2014-01-17
  • Marc Delisle

    Marc Delisle - 2012-10-18
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2012-10-20
    • priority: 5 --> 1
    • summary: Inline editing by double click --> (ok 4.0) Inline editing by double click
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2012-10-20

    Implemented for version 4.0, see $cfg['GridEditing']. Still to do, some hint to the user about what triggers grid editing.

     
  • Michal Čihař

    Michal Čihař - 2013-05-09
    • Status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     
MongoDB Logo MongoDB