Hi,
this is a very good start! Here are the needed improvements:
1. Move CSS to the themes
2. The messages you generate via jQuery should be translatable; see js/messages.php
3. For the default state of the checkbox, please take into account the current value of the global system variable foreign_key_checks
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
@lem9 Thanks for guiding me, I have now attahced a patch with some suggested improvements.
But I couldn't find the global variable foreign_key_checks. Though, there is a variable $GLOBALS['sql_disable_fk'] for exporting purposes.
Should I add a new feature for ForeignKeyChecks in the user settings section?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have updated the patch by involving server system variable 'foreign_key_checks'.
While having a look at 'Variables' tab I found 'foreign_key_checks' has been treated as GLOBAL scope variable but its a SESSION scope variable. So when editing its value from the 'Variables' tab, it shows an error.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Atul,
congratulations, I accept your patch.
About the scope, it depends on the MySQL server version. I tested in 5.1.55 and it's not GLOBAL, but in 5.5.13 it is.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi,
this is a very good start! Here are the needed improvements:
1. Move CSS to the themes
2. The messages you generate via jQuery should be translatable; see js/messages.php
3. For the default state of the checkbox, please take into account the current value of the global system variable foreign_key_checks
@lem9 Thanks for guiding me, I have now attahced a patch with some suggested improvements.
But I couldn't find the global variable foreign_key_checks. Though, there is a variable $GLOBALS['sql_disable_fk'] for exporting purposes.
Should I add a new feature for ForeignKeyChecks in the user settings section?
By "global system variable" I meant a MySQL variable, not a PHP variable. See in phpMyAdmin the "Variables" tab.
I have updated the patch by involving server system variable 'foreign_key_checks'.
While having a look at 'Variables' tab I found 'foreign_key_checks' has been treated as GLOBAL scope variable but its a SESSION scope variable. So when editing its value from the 'Variables' tab, it shows an error.
Atul,
congratulations, I accept your patch.
About the scope, it depends on the MySQL server version. I tested in 5.1.55 and it's not GLOBAL, but in 5.5.13 it is.
Your patch was merged in the repository, thanks.
Please send me (marc@infomarc.info) your email address.