(ok 4.0) Contest-2 Show index information in the data dict.

Thanks for the patch, but I cannot accept it.

There is code duplication with other parts of the code which already display the index information in other pages.

hey @lem9
I was sick and couldn't reply on my patch. I'm just back to my routine. I will reply about this patch soon.

another try, code is not duplicated now

Please have a look at code now. It is not duplicated.

This is better, but
1. please provide a patch that applies to current master
2. avoid showing the index section for a table that has no index

1. please provide a patch that applies to current master
ok will do it

2. avoid showing the index section for a table that has no index
Currently it shows index section and displays that "No index defined!"
We shouldn't show this ?

About #2, indeed it takes unnecessary room in the report.

From ee75ab459e86915b2a0dff794c8ad6b404c564b0 Mon Sep 17 00:00:00 2001
From: Muhammad Adnan <hiddenpearls@gmail.com>
Date: Thu, 22 Mar 2012 23:01:14 +0500
Subject: [PATCH] Contest-2: Show indexes information in data dictionary

---
db_datadict.php | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/db_datadict.php b/db_datadict.php
index e57206f..46f4b80 100644
--- a/db_datadict.php
+++ b/db_datadict.php
@@ -22,7 +22,7 @@ if (! isset($selected_tbl)) {
$cfgRelation = PMA_getRelationsParam();

require_once 'libraries/transformations.lib.php';
-
+require_once 'libraries/Index.class.php';

/**
* Check parameters
@@ -262,6 +262,12 @@ foreach ($tables as $table) {
$count++;
?>
</table>
+<?php
+// display indexes information
+ if(count(PMA_Index::getFromTable($table, $db))>0){
+ echo PMA_Index::getView($table, $db,true);
+ }
+?>
</div>
<?php
} //ends main while
--
1.7.5.4

Your patch was merged in the repository, thanks.