Menu ▾ ▴

#5182 KQ5 EGA: Corrupt graphics entering harpies' island

SCI: King's Quest V
closed-fixed
Filippos Karapetis
Graphics (902)
5
2010-12-01
2010-08-07
PhiloHippus
No

King's Quest V: Absence Makes the Heart Go Yonder (EGA/DOS/English), version 0.000.055
ScummVM 1.2.0svn51823

Situation: Approaching the island
Bug: Missing mountain graphics. Not present in DosBox.

Attached savegame and screenshot

Discussion

  • PhiloHippus

    PhiloHippus - 2010-08-07

    Screenshot

     
    Thumbnail
    KQ5EGAScreenshot.png

  • PhiloHippus

    PhiloHippus - 2010-08-07

    Savegame

     
    kq5.002

  • PhiloHippus

    PhiloHippus - 2010-08-07

    savegame: to enter problematic area, head south.

     

  • Filippos Karapetis

    Filippos Karapetis - 2010-09-07

    Happens when entering room 48

     

  • Filippos Karapetis

    Filippos Karapetis - 2010-09-07

    It seems that this bug is somehow caused by the way we handle priority in the picture drawing code (vector floodfill routines), in particular GfxPicture::vectorFloodFill() inside sci/graphics/picture.cpp

     

  • Filippos Karapetis

    Filippos Karapetis - 2010-09-07

    Forgot to mention that the whiteness comes from the priority screen

     

  • Filippos Karapetis

    Filippos Karapetis - 2010-11-08

    I tried to put some color clipping code in GfxPicture::vectorFloodFill(), clipping display colors to 0-15 (like in kGraphDrawLine(), kGraphFillBoxAny() and kNewWindow()). This fixes the flood fill for that scene, although the lines surrounding the flood fill are still white. Is this the proper solution for this bug, though? m_kiewitz?

     

  • Filippos Karapetis

    Filippos Karapetis - 2010-11-08
    • assigned_to: nobody --> m_kiewitz
     

  • Filippos Karapetis

    Filippos Karapetis - 2010-12-01
    • assigned_to: m_kiewitz --> thebluegr
    • status: open --> closed-fixed
     

  • Filippos Karapetis

    Filippos Karapetis - 2010-12-01

    Fixed in rev #54690

     
Auth0 Logo