pywikibot / Bugs / #1182 .nice_get_address() used but not implemented

Python MediaWiki Bot Framework

#1182 .nice_get_address() used but not implemented

Status: closed-fixed

Owner: Russell Blau

Labels: rewrite (44)

Priority: 5

Updated: 2010-05-19

Created: 2010-05-17

Creator: stanlekub

Private: No

In the rewrite branch, the Site.nice_get_address() method is marked as 'NotImplemented' but is used in various scripts,
namely :
* pagegenerators.py (to set the 'site:' attribute of Google and Yahoo search queries)
* replace.py and interwiki.py for the 'open in browser' options.

As I'm unsure if the NotImplemented status means "not implemented yet" or "will not implement",
I propose two patches:
* The first one wich works around using Family.nicepath()
* The second one which implements nice_get_address() "the old way", removing it from the NotImplemented pool.

Discussion

stanlekub - 2010-05-17

Patch for replacing nice_get_address() calls with nicepath()

patch1.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

stanlekub - 2010-05-17

The second file, implementing nice_get_address()

patch2.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Russell Blau - 2010-05-19

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Russell Blau - 2010-05-19

Fixed in r8198: I applied your second patch, but added a more API-aware override in APISite.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

.nice_get_address() used but not implemented

Python MediaWiki Bot Framework

Group

Searches

Help

#1182 .nice_get_address() used but not implemented

Discussion