Menu ▾ ▴

#523 (ok 3.3.3)LeftFrameTableSeparator should not group with one

closed-accepted
Michal Čihař
Interface (183)
1
2014-03-19
2010-04-06
Lori Lee
No

This patch is for this bug: https://sourceforge.net/tracker/?func=detail&aid=2938291&group_id=23067&atid=377411

When there are multiple tables in a database with the same prefix, PMA groups them together. However, if there is only one table then there should be no grouping.

Discussion

  • Lori Lee

    Lori Lee - 2010-04-06

    diff of the code

     
    2938291.diff

  • Lori Lee

    Lori Lee - 2010-04-06

    screenshot of what it looked like before

     
    Thumbnail
    bug_screenshot.png

  • Michal Čihař

    Michal Čihař - 2010-04-06
    • assigned_to: nobody --> nijel
     

  • Michal Čihař

    Michal Čihař - 2010-04-06

    Your patch works as expected, however I have few comments:

    1. please document what the code is supposed to do, especially the for loop is non obvious
    2. please keep coding style, you use mix of tabs and spaces to indent

     

  • Lori Lee

    Lori Lee - 2010-04-06

    updated diff with comments and proper formatting

     
    2938291-2.diff

  • Michal Čihař

    Michal Čihař - 2010-04-07
    • priority: 5 --> 1
    • summary: LeftFrameTableSeparator should not group if only one --> (ok 3.4)LeftFrameTableSeparator should not group if only one
    • status: open --> open-accepted
     

  • Michal Čihař

    Michal Čihař - 2010-04-07

    Your patch was merged in the repository, thanks.

     

  • Michal Čihař

    Michal Čihař - 2010-04-07
    • summary: (ok 3.4)LeftFrameTableSeparator should not group if only one --> (ok 3.3.3)LeftFrameTableSeparator should not group with one
     

  • Marc Delisle

    Marc Delisle - 2010-05-10
    • status: open-accepted --> closed-accepted
     
MongoDB Logo MongoDB