Menu

#512 (ok 3.3.2) Fixes bug #2960105

closed-accepted
1
2010-04-14
2010-03-30
Nate
No

This patch allows for all Unicode characters to be imported from an ODS file.

Discussion

  • Nate

    Nate - 2010-03-30

    Initial patch, open to review

     
  • Michal Čihař

    Michal Čihař - 2010-03-30

    According to the documentation, utf8_decode works only for iso-8859-2 so it does not look like it will allow all Unicode characters.

     
  • Nate

    Nate - 2010-03-30

    Thank you for pointing that out. Actually, it does work because the data is passed through utf8_encode() on line 71 of ods.php unnecessarily. But now that I look at that more closely, I can't figure out any benefit of the utf8_encode(), so it looks like we could just remove both functions without any problems.

    I have tested this with a wide range of symbols, including Arabic letters and Chinese symbols.

     
  • Nate

    Nate - 2010-03-30

    Improvements to patch

     
  • Michal Čihař

    Michal Čihař - 2010-03-31
    • assigned_to: nobody --> nijel
     
  • Michal Čihař

    Michal Čihař - 2010-03-31
    • priority: 5 --> 1
    • summary: Fixes bug #2960105 --> (ok 3.3.2) Fixes bug #2960105
     
  • Michal Čihař

    Michal Čihař - 2010-03-31

    Your patch was merged in the repository, thanks.

     
  • Michal Čihař

    Michal Čihař - 2010-04-07
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2010-04-14
    • status: open-accepted --> closed-accepted