Menu

#3005 (ok 3.3.2) SQL History

3.2.5
fixed
1
2014-08-16
2010-03-21
No

SQL History does not show history.

I've tried debugging a bit. $_SESSION['sqlhistory'][key] is create after running the SQL statements. However, after clicking onto next page, this $_SESSION['sqlhistory'][key] is no longer available.

The change in 3.2.4 to 3.2.5 introduced this bug.

I have tried >3.2.5, it all produces this but not 3.2.4.

Test Case:
- Select a random table in a database
- Open Query Window -> SQL History
SQL History should show the first SELECT * statement, but it doesn't. Further selecting other tables doesn't show up in history too.

Discussion

  • Dieter Adriaenssens

    I was able to reproduce it in 3.2.5 and 3.3.2-dev
    The SQL History functionality (storing in a SESSION) was broken by
    patch #2899969 [core] Session lock blocks working from a second window
    in commit 6ec65aafe3ebef85375fcf3600dece10902e045b

    This patch introduces an end of session, to remove a session lock. When the SQLhistory is copied to $_SESSION['sql_history'] at a later stage, the session is already closed, so the Query is not stored in $_SESSION['sql_history'].

     
  • Dieter Adriaenssens

    • status: open --> open-accepted
     
  • Dieter Adriaenssens

    • milestone: --> 3.2.5
     
  • Marc Delisle

    Marc Delisle - 2010-04-04

    Hey! I merged this patch ;)

     
  • Marc Delisle

    Marc Delisle - 2010-04-04
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2010-04-04

    Patch 2899969 reverted, for 3.3.2.

     
  • Marc Delisle

    Marc Delisle - 2010-04-04
    • priority: 5 --> 1
    • summary: SQL History --> (ok 3.3.2) SQL History
    • status: open-accepted --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2010-04-14
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     
MongoDB Logo MongoDB