Menu
▾
▴
#4669 NIPPON: No Elder
After picking up leaves and entering monastery you should be taken to the elder to answer some questions but your just led to the front of the monastery. You can only go back to the previous screen and relive it again never to move any further forward.
Nippon Safes Inc. (Multi-lingual/DOS) - English
ScummVM 1.0.0pre045149 (win32)
Windows 7 (x64)
Save Game
This bug is nice to get fixed before the release. Raising priority for keeping the track.
Confirmed that this bug is still there as of 1.3.0svn r52876. Renders Doug's section impossible to complete.
I confirmed this with 1.3.0svn54757
Replicated this with Nippon Safes(Amiga) and :
ScummVM 1.4.0git1778-gd13a927-dirty (Aug 24 2011 02:11:34)
Features compiled in: Vorbis FLAC MP3 ALSA SEQ TiMidity RGB zLib FluidSynth Theora AAC
From clean new game as well as from the attached save state.
Will try to bisect for cause.
Thr following are some details on the cause of this from peres:
<snip>
The Elder's screen should appear when you exit the location through
the lower part of the screen, triggered by a Zone in the scripts
*when the character stops walking*. What happens instead is that the
normal location switch code executes *as soon as* the character's y
coordinate is greater than the screen vertical size.
The problem was introduced after I merged the walk input loop
with the main input loop, so it's basically a priority issue.
I was meaning to fix this using a flag to disable portions of the
main loop when the character is walking, but time has always lacked.
<end snip>
Initial Bodge Fix (Help To Trace Root Cause)
Attached a workaround bodged fix which avoids this issue. This is not a usable solution, but it eludicates the cause.
Slightly Better Fix (Prevent checkDoor in Pathfinding when called by Script)
Attached patch for slightly better fix. This works by blocking checkDoor() (which is called when the last node in a walking path is reached) when the walking is triggered by a script, rather than by the user. This fixes the issue, but is not a good fix as scripts do expect locationChange via door in most cases by moving to the hitZone i.e. after you pick up all the leaves and talk to the Monk, Dough and the Monk stop in the doorway now... however, this is not fatal as clicking on the doorway allows you to continue.
Fixed in commit 2883ebc (same cause as bug #3135868)