Add JavaScript validation to data entry forms

Brought to you by: ahasuerus_isfdb, alvonruff, mkupper

#74 Add JavaScript validation to data entry forms

Milestone: Approved

Status: closed

Owner: Ahasuerus

Labels: Editor Interface (108)

Priority: 6

Updated: 2013-12-21

Created: 2009-06-12

Creator: David E. Siegel

Private: No

Was Feature:90089 on the ISFDB wiki. An editor submitted a publication date as YYYYMM-DD which I accepted and then corrected as ISFDB interpreted it as 0000-00-00. At present ISFDB works with YYYYMMDD or YYYY-MM-DD. My thinking is that that some up-front validation could allow for
o YYYY
o YYYYMM
o YYYY-MM (it took me a while to train the fingers to add -00…)
o YYYYMMDD
o YYYY-MM-DD

Other patterns would be refused with help on the correct format/syntax. The YYYY, MM, and DD value ranges can be validated too with the year allowing 0000, 1000 to now+2 years, and 8888. Marc Kupper 14:34, 29 Dec 2006 (CST)

(Copied from Community Portal as it seems relevant to this issue Marc Kupper 23:41, 3 Jan 2007 (CST)) When one wants to create a New Title, the date entry can apparently consist of nothing but 1956, say, instead of 1956-00-00 and that date then appears when the book is posted. But, as I have just discovered on my own (and Marc has pointed out to me) if one wants to *add* a date to an already existing Title, then one *has* to use the YYYY-MM-DD format in order to get anything at all to show up. A very minor quibble, to be sure, but life is tough enough without one more inconsistency to remember, hehe.... Hayford Peirce 18:53, 3 Jan 2007 (CST)

Discussion

Ahasuerus - 2010-12-29

Added browser-based validation of dates (and some other fields) to the Edit Title page. Similar validation will be added to New Pub, Edit Pub and other pages once this round of changes has been live for a few days.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2012-11-12

Changed the title to cover more data elements rather than just dates.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2012-11-12

priority: 5 --> 6

summary: Validate or correct date formatting --> Add JavaScript validation to data entry forms
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Darrah Chavey - 2013-06-24

Should add validation that the author field of a content item has been filled, else the system reports an error and gives no option to back up to recover the data (although some browsers will recover it by going "back"). Similarly, if an author field is filled in but the content title is blank, it gives the same type of error, also threatening to discard the data that was entered.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-10-14

Added JabaScript validation to Edit Author. It now checks that the two required fields, "Canonical Author" and "Last Name", have been specified and that the Canonical name doesn't contain double quotes.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-10-15

Added date validation to Author Edit in edit/isfdblib.py 1.36. Installed in r2013-134 on 2013-10-14.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-10-15

Added JS validation to Add/Edit Award in:

edit/addaward.py 1.13 edit/editaward.py 1.10 edit/isfdblib.py 1.37

Installed on r2013-135 on 2013-10-15.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous - 2013-10-16

Added JS validation to Add Variant and Make Variant in:

edit/addvariant.py 1.13
edit/isfdblib.py 1.38
edit/mkvariant.py 1.15
edit/submitmkvariant2.py 1.11
*edit/submitvariant.py 1.7

Installed in r2013-136 on 2013-10-15.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-10-21

Added title, author, URL and date validation of the metadata section in New Pub. Added title-author-reviewer-interviewer-date consistency validation to the Contents section of New Pub. Scripts modified:

edit/newpub.py 1.21 edit/isfdblib.py 1.40

Installed in r2013-140 on 2013-10-20.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-10-29

Added JS validation to Edit Pub and Clone Pub in:

edit/clonepub.py 1.23 edit/editpub.py 1.22 edit/isfdblib.py 1.42

Installed in r2013-143 on 2013-10-29.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-12-21

Closing this FR since it covers too many Web pages. Will create separate FRs for individual pages which still need to have this functionality added.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Ahasuerus - 2013-12-21

status: open --> closed

assigned_to: Ahasuerus

Group: --> Approved
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Anonymous
  
  Add attachments
  Cancel
  You seem to have CSS turned off. Please don't fill out this field.
  
  You seem to have CSS turned off. Please don't fill out this field.

Anonymous