Menu

#1164 (ok 3.4) Use inline query editing

fixed
1
2013-06-11
2009-06-11
No

After executing a query, the Edit button opens a new window. Would it be possible to do the editing in place? For example, by using a textarea to display the query?

Discussion

1 2 > >> (Page 1 of 2)
  • Marc Delisle

    Marc Delisle - 2009-07-23
    • assigned_to: nobody --> lem9
    • status: open --> pending-works-for-me
     
  • Marc Delisle

    Marc Delisle - 2009-07-23

    Use
    $cfg['EditInWindow'] = false;

     
  • Olaf van der Spek

    • status: pending-works-for-me --> open-works-for-me
     
  • Olaf van der Spek

    Any chance to get that by default?

     
  • Marc Delisle

    Marc Delisle - 2009-07-23
    • status: open-works-for-me --> pending-works-for-me
     
  • Marc Delisle

    Marc Delisle - 2009-07-23

    We have zero chances to please everyone with the default configurations.

     
  • Olaf van der Spek

    • status: pending-works-for-me --> open-works-for-me
     
  • Olaf van der Spek

    True, but the right question would be which of the two would please more people.

     
  • Marc Delisle

    Marc Delisle - 2009-07-23

    I guess it's the current setting as I don't remember having seen other complaints.

     
  • Marc Delisle

    Marc Delisle - 2009-07-23

    Fine, you found one other complaint.

     
  • Olaf van der Spek

    What's the advantage of the new window?

     
  • Marc Delisle

    Marc Delisle - 2009-07-23

    When fine-tuning a query you make your changes in the separate window, click Go, see the results and can immediately change your query and test again.

     
  • Olaf van der Spek

    Isn't that also the case when you use a edit field on the original page?

     
  • Isaac Bennetch

    Isaac Bennetch - 2009-07-23

    If I may jump in, I think it should remain the same so as to not confuse users. I spend a lot of time in the IRC channel and here on the support forums, and people don't handle needless change well. They don't even handle necessary changes well.

    While I personally don't like the new window, it's easy enough to change in config.inc.php and hopefully soon the per-user configuration database. I'm just pointing out that people are easily confused when familiar things suddenly are different.

     
  • Olaf van der Spek

    I don't agree. In that case we'd get stuck in the last century.

     
  • Marc Delisle

    Marc Delisle - 2009-07-24

    I agree with ibennetch.

     
  • Marc Delisle

    Marc Delisle - 2009-07-24
    • status: open-works-for-me --> pending-works-for-me
     
  • Olaf van der Spek

    Ok, I guess the default won't be changed.
    With $"cfg['EditInWindow'] = false;" it still takes a page refresh to start editing. Wouldn't it be possible to show the textarea right away or to use JS to show it dynamically?

     
  • Olaf van der Spek

    • status: pending-works-for-me --> open-works-for-me
     
  • Marc Delisle

    Marc Delisle - 2009-07-24

    I think this could be possible.

     
  • Marc Delisle

    Marc Delisle - 2009-07-24
    • assigned_to: lem9 --> nobody
    • status: open-works-for-me --> open
     
  • Olaf van der Spek

    > If I may jump in, I think it should remain the same so as to not confuse
    users.

    Why would users get confused?

     
  • Arcadiy Fedushin

    IMHO both "$cfg['EditInWindow'] = false;" by default and JS-showing additional TEXTAREA to edit SQL and run it again would be user-friendly.

     
  • Muhammad Adnan

    Muhammad Adnan - 2010-03-27

    I am working on this feature. I am posting this comment. So, no one is duplicating.
    Ok Marc ?

     
1 2 > >> (Page 1 of 2)