phpMyAdmin / Patches / #446 (ok 3.2) Result sorting

#446 (ok 3.2) Result sorting

Status: closed-accepted

Owner: Marc Delisle

Labels: Displaying results (34)

Priority: 1

Updated: 2009-06-15

Created: 2009-01-30

Creator: Virsacer

Private: No

The check for metadata "orgname" is wrong so the sort link is incomplete:
SELECT COUNT(*) AS `Rows`, `type` FROM `table` GROUP BY `type`

If a query contains an ORDER BY without the table name there are no sort-arrows:
SELECT COUNT(*) AS `Rows`, `type` FROM `table` GROUP BY `type` ORDER BY `type`

Discussion

Virsacer - 2009-01-30

patch.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-01-31

better solution

patch2.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-02-01

assigned_to: nobody --> lem9
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-02-01

assigned_to: lem9 --> nobody
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Michal Čihař - 2009-03-03

Why did you remove strlen($fields_meta[$i]->table)?

Also some comment what does the if actually do would be welcome.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-03-03

I replaced "isset && strlen" by "!empty"...

And my "if" adds the name of the table to the compare-string if it is not already in it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-03-03

Some time ago we replaced the "! empty" syntax with "strlen()" to catch the case of a table name "0".

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-03-03

Well then both have to be "strlen"...

The "isset" is not neccessary - it can only have a length if it is set...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-03-03

Updated

patch3.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-03-04

If $fields_meta[$i]->table is not set, you get a notice if you call strlen() on it.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-03-05

Ok, I updated my patch...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Virsacer - 2009-03-05

updated

patch4.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-03-17

assigned_to: nobody --> lem9
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-03-17

Merged in subversion, thanks.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-03-17

priority: 5 --> 1

summary: Result sorting --> (ok 3.2) Result sorting

status: open --> open-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Marc Delisle - 2009-06-15

status: open-accepted --> closed-accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

(ok 3.2) Result sorting

A software tool to bring MySQL to the Web

Group

Searches

Help

#446 (ok 3.2) Result sorting

Discussion