However in my tests, patch2.diff changes nothing in PMA's behavior in the case when $cfg['Servers'][$i]['table_info'] is not defined or contains a wrong value.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
For your first fix, in fact we need to check both $GLOBALS['cfgRelation']['relwork'] and $GLOBALS['cfgRelation']['displaywork'].
For your second fix, you're right: using isset() to test if something is true is not a good idea.
Merged with small modifications, thanks.
I think you are wrong about the second one:
We want to check if the user set a table for relation views.
What you mean is in the next line.
Compare a few lines below: designer_coords and designerwork
BTW: the first check ($GLOBALS['cfg']['Server']['pmadb']) should also be isset()
It has to be !empty($GLOBALS['cfg']['Server']['pmadb'])
Sorry, I don't understand what you mean. Please attach here a patch2.diff against current trunk, with your suggestions.
It has to be a check if the tablename for relation view is set in config
I know that this is only a rare used status display but it should still be correct...
As I said:
Please attach here a patch2.diff
against current trunk, with your suggestions.
I added the patch2.diff over a week ago
(44 minutes after you asked for it)
It is still against current trunk.
Sorry I had not noticed.
However in my tests, patch2.diff changes nothing in PMA's behavior in the case when $cfg['Servers'][$i]['table_info'] is not defined or contains a wrong value.
Check what happens when you set "table_info" but not "relation"...
Thanks for the test case. patch2.diff now merged for 3.1.3.