Menu

#441 (ok 3.2) server_privileges.php cleanup

closed-accepted
Privileges (8)
1
2009-06-15
2009-01-13
Virsacer
No

There is a problem with the user-host-seperator when deleting users.

Discussion

  • Marc Delisle

    Marc Delisle - 2009-01-13

    You mean a problem introduced by your other patch?

     
  • Marc Delisle

    Marc Delisle - 2009-01-13
    • assigned_to: nobody --> lem9
     
  • Virsacer

    Virsacer - 2009-01-14

    No, it must have been there before.

     
  • Marc Delisle

    Marc Delisle - 2009-01-14

    Please tell me what is the problem you are talking about, that would exist on current trunk which does not contain your patch about XHTML fix for server_privileges.php.

     
  • Virsacer

    Virsacer - 2009-01-14

    Yes, you are right:
    It was a an error by the HTML cleanup in my working copy.
    I got this: DROP USER 'deleteme'@'';

    This patch ist still a simplification though...

     
  • Marc Delisle

    Marc Delisle - 2009-01-17

    Which problem does your new patch version solve? (Your XHTML fix for server_privileges.php is not part of trunk).

     
  • Marc Delisle

    Marc Delisle - 2009-01-20
    • status: open --> pending
     
  • Virsacer

    Virsacer - 2009-01-26
     
  • Virsacer

    Virsacer - 2009-01-26
     
  • Virsacer

    Virsacer - 2009-01-26

    So here is the new extended version.
    Changes in order of appearance:

    1. typo in comment

    2. var only used once because of change 3

    2a. this is where the var was still used

    2b. result of change 3

    3. valid html
    & why replace something that was just inserted?
    4. use the same url-format from database to user as from useroverview to user

    4a. % is also a wildcard

    4b. if-block within if-block with same condition
    & use plural if database is wildcard
    & use same url-format from table to database as from user to database

    5. valid html

    6. typo in comment

    7. show links to database/table only if database is no wildcard

     
  • Virsacer

    Virsacer - 2009-01-26
    • summary: DROP USER -> SQL error --> server_privileges.php cleanup
    • status: pending --> open
     
  • Marc Delisle

    Marc Delisle - 2009-01-26

    Thanks, I'll try this ASAP. The patchLF.diff applies correctly on my machine.

     
  • Marc Delisle

    Marc Delisle - 2009-01-27

    Merged in subversion, thanks.

     
  • Marc Delisle

    Marc Delisle - 2009-01-27
    • priority: 5 --> 1
    • summary: server_privileges.php cleanup --> (ok 3.2) server_privileges.php cleanup
    • status: open --> open-accepted
     
  • Marc Delisle

    Marc Delisle - 2009-06-15
    • status: open-accepted --> closed-accepted