Menu

#2808 (ok 3.2) AllowNoPasswordRoot error message is too vague

fixed
1
2013-06-11
2008-12-10
No

When a user with a blank password for 'root' tries to log in (presuming AllowNoPasswordRoot=false), the error message is "Access denied" -- this is too vague and we should give them at least a hint as to what is wrong and ideally a tip on how to set the password.

I'd gladly submit the patch myself but can't find the logic for dealing with this -- the error message appears to be strAccessDenied but the only references I find to that string in the codebase relate to the Allow/Deny ruleset. So hints are welcome.

Thanks

Discussion

  • Michal Čihař

    Michal Čihař - 2008-12-11

    Yes, the same message is used. The code is in libaries/common.inc.php and it calls PMA_auth_fails from active auth method, which displays error message based on some global variables.

    On the other side - it was quite intentional to use same error message. Do you think it is good idea to make publicly available information that you have root user without password?

     
  • Marc Delisle

    Marc Delisle - 2009-01-14

    Michal,
    if a user tries root without a password and we reply that root without a password is not allowed for this PMA installation, we are not revealing anything about user root.

     
  • Marc Delisle

    Marc Delisle - 2009-02-10
    • labels: 509328 --> Authentication issues
    • assigned_to: nobody --> lem9
     
  • Marc Delisle

    Marc Delisle - 2009-02-10

    Fixed in subversion, thanks for reporting.

     
  • Marc Delisle

    Marc Delisle - 2009-02-10
    • priority: 5 --> 1
    • summary: AllowNoPasswordRoot error message is too vague --> (ok 3.2) AllowNoPasswordRoot error message is too vague
    • status: open --> open-fixed
     
  • Marc Delisle

    Marc Delisle - 2009-02-10

    Fixed (at least for cookie auth).

     
  • Marc Delisle

    Marc Delisle - 2009-06-15
    • status: open-fixed --> closed-fixed
     
  • Michal Čihař

    Michal Čihař - 2013-06-11
    • Status: closed-fixed --> fixed
     
MongoDB Logo MongoDB